Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 5222955109842944: Add plumbing for platform based Device Motion testing. (Closed)

Created:
7 years, 5 months ago by timvolodine
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add plumbing for platform based Device Motion testing. This CL implements injection of a mock WebDeviceMotionData into the Platform for testing purposes. Once the mock WebDeviceMotionData is set it will be returned as a one-shot event once Blink registers its DeviceMotionListener through the platform using setDeviceMotionListener method. BUG=135804 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212084

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed comments, removed webkit/support files #

Patch Set 3 : forward declare of WebDeviceMotionData #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M content/public/test/layouttest_support.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 3 chunks +21 lines, -4 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
timvolodine
7 years, 5 months ago (2013-07-11 19:55:41 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://chromiumcodereview.appspot.com/5222955109842944/diff/5629499534213120/content/renderer/renderer_webkitplatformsupport_impl.h File content/renderer/renderer_webkitplatformsupport_impl.h (right): https://chromiumcodereview.appspot.com/5222955109842944/diff/5629499534213120/content/renderer/renderer_webkitplatformsupport_impl.h#newcode154 content/renderer/renderer_webkitplatformsupport_impl.h:154: static void SetMockDeviceMotionDataForTesting( nit. please add a comment ...
7 years, 5 months ago (2013-07-15 13:55:08 UTC) #2
timvolodine
https://chromiumcodereview.appspot.com/5222955109842944/diff/5629499534213120/content/renderer/renderer_webkitplatformsupport_impl.h File content/renderer/renderer_webkitplatformsupport_impl.h (right): https://chromiumcodereview.appspot.com/5222955109842944/diff/5629499534213120/content/renderer/renderer_webkitplatformsupport_impl.h#newcode154 content/renderer/renderer_webkitplatformsupport_impl.h:154: static void SetMockDeviceMotionDataForTesting( On 2013/07/15 13:55:08, jochen wrote: > ...
7 years, 5 months ago (2013-07-16 11:53:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/5222955109842944/6001
7 years, 5 months ago (2013-07-16 11:59:12 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-16 12:56:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/5222955109842944/24001
7 years, 5 months ago (2013-07-17 10:22:23 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 17:46:11 UTC) #7
Message was sent while issue was closed.
Change committed as 212084

Powered by Google App Engine
This is Rietveld 408576698