Make git-cl-land wait

Make git-cl-land wait

R=vadimsh@chromium.org
BUG=406198
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291719

[Michael Moss, 2014-08-29 01:03:27]

mmoss@chromium.org changed reviewers:
+ mmoss@chromium.org

[Michael Moss, 2014-08-29 01:03:27]

lgtm

[Vadim Sh., 2014-08-29 01:09:38]

https://codereview.chromium.org/519563002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/519563002/diff/1/git_cl.py#newcode2098
git_cl.py:2098: target_tree = RunGit(['rev-parse', 'HEAD:']).strip()
Is HEAD really what you want here? HEAD is cl.GetBranch() (whatever it is).

https://codereview.chromium.org/519563002/diff/1/git_cl.py#newcode2099
git_cl.py:2099: current_rev = RunGit(['rev-parse', local_base_ref]).strip()
It's latest local revision fetched from remote?

https://codereview.chromium.org/519563002/diff/1/git_cl.py#newcode2107
git_cl.py:2107: RunGit(['retry', 'fetch', remote, real_ref],
stderr=subprocess2.VOID)
let's remove stderr supression, people want to know what's going on...

https://codereview.chromium.org/519563002/diff/1/git_cl.py#newcode2108
git_cl.py:2108: to_rev = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
print this rev? so that people see that it's crawling... dunno...

[iannucci, 2014-08-29 01:24:25]

https://chromiumcodereview.appspot.com/519563002/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/519563002/diff/1/git_cl.py#newcode2098
git_cl.py:2098: target_tree = RunGit(['rev-parse', 'HEAD:']).strip()
On 2014/08/29 01:09:37, Vadim Sh. wrote:
> Is HEAD really what you want here? HEAD is cl.GetBranch() (whatever it is).

Fixed in PS2

https://chromiumcodereview.appspot.com/519563002/diff/1/git_cl.py#newcode2099
git_cl.py:2099: current_rev = RunGit(['rev-parse', local_base_ref]).strip()
On 2014/08/29 01:09:37, Vadim Sh. wrote:
> It's latest local revision fetched from remote?

yeah

https://chromiumcodereview.appspot.com/519563002/diff/1/git_cl.py#newcode2107
git_cl.py:2107: RunGit(['retry', 'fetch', remote, real_ref],
stderr=subprocess2.VOID)
On 2014/08/29 01:09:37, Vadim Sh. wrote:
> let's remove stderr supression, people want to know what's going on...

the fetching line above is enough. This just spams the same thing over and over

https://chromiumcodereview.appspot.com/519563002/diff/1/git_cl.py#newcode2108
git_cl.py:2108: to_rev = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
On 2014/08/29 01:09:37, Vadim Sh. wrote:
> print this rev? so that people see that it's crawling... dunno...

nah, it's too fast. spends all its time fetching

[Vadim Sh., 2014-08-29 01:32:17]

lgtm

[iannucci, 2014-08-29 01:35:24]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-08-29 01:36:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/iannucci@chromium.org/519563002/20001

[commit-bot: I haz the power, 2014-08-29 01:38:05]

Committed patchset #2 (id:20001) as 291719