Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: extensions/common/manifest_constants.cc

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address yoz's comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_constants.cc
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc
index 9aa20fd3f0531c433bd9d2e528116607185566fc..837bc9f33dde79b5a0a3e69799746d4d3fe228bd 100644
--- a/extensions/common/manifest_constants.cc
+++ b/extensions/common/manifest_constants.cc
@@ -95,6 +95,7 @@ const char kOmnibox[] = "omnibox";
const char kOmniboxKeyword[] = "omnibox.keyword";
const char kOptionalPermissions[] = "optional_permissions";
const char kOptionsPage[] = "options_page";
+const char kOptionsUI[] = "options_ui";
const char kOverrideHomepage[] = "chrome_settings_overrides.homepage";
const char kOverrideSearchProvider[] =
"chrome_settings_overrides.search_provider";
@@ -513,13 +514,16 @@ const char kInvalidOfflineEnabled[] =
"Invalid value for 'offline_enabled'.";
const char kInvalidOmniboxKeyword[] =
"Invalid value for 'omnibox.keyword'.";
-const char kInvalidOptionsPage[] =
- "Invalid value for 'options_page'.";
+const char kInvalidOptionsPage[] = "Invalid value for '*'.";
const char kInvalidOptionsPageExpectUrlInPackage[] =
"Invalid value for 'options_page'. Value must be a relative path.";
const char kInvalidOptionsPageInHostedApp[] =
"Invalid value for 'options_page'. Hosted apps must specify an "
"absolute URL.";
+const char kInvalidOptionsUIChromeStyle[] =
+ "Invalid value for 'options_ui.chrome_style'.";
+const char kInvalidOptionsUIOpenInTab[] =
+ "Invalid value for 'options_ui.open_in_tab'.";
const char kInvalidPageAction[] =
"Invalid value for 'page_action'.";
const char kInvalidPageActionDefaultTitle[] =

Powered by Google App Engine
This is Rietveld 408576698