[Presubmit] Make CSS checker ignore '@' inside of strings.

[Presubmit] Make CSS checker ignore '@' inside of strings.

This fixes the bug where url('google_logo.png@2x') causes validation
failures.

BUG=408759
R=dbeam@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/99abda3dd6b692269c036fe83dcc4e3d729e8241

[huangs, 2014-08-28 21:37:13]

huangs@chromium.org changed reviewers:
+ dbeam@chromium.org

[huangs, 2014-08-28 21:37:13]

PTAL.  This is needed for the CL

https://codereview.chromium.org/512583002/

Thanks!.

[huangs, 2014-08-29 16:04:28]

Ping dbeam@ for comments.

[Dan Beam, 2014-09-03 18:38:07]

please update the tests

[Dan Beam, 2014-09-03 18:38:42]

chrome/browser/test_presubmit.py

[huangs, 2014-09-03 20:46:39]

Added unit test, and verified that it fails without the fix.  PTAL.

[Dan Beam, 2014-09-03 21:18:01]

lgtm

https://chromiumcodereview.appspot.com/514403002/diff/20001/chrome/browser/te...
File chrome/browser/test_presubmit.py (right):

https://chromiumcodereview.appspot.com/514403002/diff/20001/chrome/browser/te...
chrome/browser/test_presubmit.py:531: }
^ do you need this filler?  i doubt this would ever make it through review so
it's not similar to what this checker would actually be running on

[huangs, 2014-09-03 21:38:48]

Response to comment.

https://chromiumcodereview.appspot.com/514403002/diff/20001/chrome/browser/te...
File chrome/browser/test_presubmit.py (right):

https://chromiumcodereview.appspot.com/514403002/diff/20001/chrome/browser/te...
chrome/browser/test_presubmit.py:531: }
Yup, the filler is needed.  Consider the old RegEx, and look at the test case:

RegEx: @\w+.*?{(.*{.*?}).*?} 
Breakdown:
(skipping #logo {...)
@\w+  => @2x
.*?{  => ');\n}\n\nbody.alternate-logo #logo {
(
.*{   => '\n  -webkit ...  none;\n}\n\n.filler1 {'
.*?}  => '\n}'
)
.*?}  => '\n\n.filler2 {\n}'

Perhaps "filler" is a misnomer.  Maybe "stuff" would work better?

[huangs, 2014-09-03 23:08:15]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-09-03 23:23:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/huangs@chromium.org/514403002/40001

[Dan Beam, 2014-09-03 23:55:18]

https://codereview.chromium.org/514403002/diff/40001/chrome/browser/test_pres...
File chrome/browser/test_presubmit.py (right):

https://codereview.chromium.org/514403002/diff/40001/chrome/browser/test_pres...
chrome/browser/test_presubmit.py:527: .stuff1 {
can you just put something into these empty blocks?

[commit-bot: I haz the power, 2014-09-04 01:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 01:29:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[huangs, 2014-09-05 04:37:08]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-09-05 04:39:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/huangs@chromium.org/514403002/40001

[commit-bot: I haz the power, 2014-09-05 04:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 04:53:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[huangs, 2014-09-06 04:12:40]

Committed patchset #4 (id:60001) manually as 99abda3 (presubmit successful).

[commit-bot: I haz the power, 2014-09-10 03:42:13]

Patchset 4 (id:??) landed as
https://crrev.com/99abda3dd6b692269c036fe83dcc4e3d729e8241
Cr-Commit-Position: refs/heads/master@{#293603}

[huangs, 2014-09-12 14:09:43]

Patchset #5 (id:80001) has been deleted