Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: extensions/common/manifest_handler.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test and clang presubmit errors. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_handler.h ('k') | extensions/common/permissions/api_permission_set.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handler.cc
diff --git a/extensions/common/manifest_handler.cc b/extensions/common/manifest_handler.cc
index 43e6bd80e2563d57c1075a0f52ac7b8556e5e973..944389d6a9fc235df27fc1678f93ea72469f10de 100644
--- a/extensions/common/manifest_handler.cc
+++ b/extensions/common/manifest_handler.cc
@@ -9,6 +9,8 @@
#include "base/logging.h"
#include "base/stl_util.h"
#include "chrome/common/extensions/extension.h"
+#include "extensions/common/permissions/manifest_permission.h"
+#include "extensions/common/permissions/manifest_permission_set.h"
namespace extensions {
@@ -57,6 +59,15 @@ void ManifestHandler::Register() {
GetRegistry()->RegisterManifestHandler(keys[i], this_linked);
}
+ManifestPermission* ManifestHandler::CreatePermission() {
+ return NULL;
+}
+
+ManifestPermission* ManifestHandler::CreateInitialRequiredPermission(
+ const Extension* extension) {
+ return NULL;
+}
+
// static
void ManifestHandler::FinalizeRegistration() {
GetRegistry()->Finalize();
@@ -80,6 +91,18 @@ bool ManifestHandler::ValidateExtension(const Extension* extension,
}
// static
+ManifestPermission* ManifestHandler::CreatePermission(const std::string& name) {
+ return GetRegistry()->CreatePermission(name);
+}
+
+// static
+void ManifestHandler::AddExtensionInitialRequiredPermissions(
+ const Extension* extension, ManifestPermissionSet* permission_set) {
+ return GetRegistry()->AddExtensionInitialRequiredPermissions(extension,
+ permission_set);
+}
+
+// static
const std::vector<std::string> ManifestHandler::SingleKey(
const std::string& key) {
return std::vector<std::string>(1, key);
@@ -144,6 +167,27 @@ bool ManifestHandlerRegistry::ValidateExtension(
return true;
}
+ManifestPermission* ManifestHandlerRegistry::CreatePermission(
+ const std::string& name) {
+ ManifestHandlerMap::const_iterator it = handlers_.find(name);
+ if (it == handlers_.end())
+ return NULL;
+
+ return it->second->CreatePermission();
+}
+
+void ManifestHandlerRegistry::AddExtensionInitialRequiredPermissions(
+ const Extension* extension, ManifestPermissionSet* permission_set) {
+ for (ManifestHandlerMap::const_iterator it = handlers_.begin();
+ it != handlers_.end(); ++it) {
+ ManifestPermission* permission =
+ it->second->CreateInitialRequiredPermission(extension);
+ if (permission) {
+ permission_set->insert(permission);
+ }
+ }
+}
+
// static
ManifestHandlerRegistry* ManifestHandlerRegistry::SetForTesting(
ManifestHandlerRegistry* new_registry) {
« no previous file with comments | « extensions/common/manifest_handler.h ('k') | extensions/common/permissions/api_permission_set.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698