chrome/common/extensions/permissions/permissions_data_unittest.cc - Issue 51433002: Enable permission warnings from ManifestHandlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permissions_data_unittest.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit test and clang presubmit errors. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/permissions/permissions_data_unittest.cc

diff --git a/chrome/common/extensions/permissions/permissions_data_unittest.cc b/chrome/common/extensions/permissions/permissions_data_unittest.cc

index c2bdb07620c68d3a381d7ade2be45137179b24e7..f4e0d3ef35b9314824dd9df174b7852e0dca68fa 100644

--- a/chrome/common/extensions/permissions/permissions_data_unittest.cc

+++ b/chrome/common/extensions/permissions/permissions_data_unittest.cc

@@ -548,7 +548,8 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {

{

scoped_refptr<PermissionSet> permissions(

- new PermissionSet(APIPermissionSet(), allowed_hosts, URLPatternSet()));

+ new PermissionSet(APIPermissionSet(), ManifestPermissionSet(),

+ allowed_hosts, URLPatternSet()));

PermissionsData::UpdateTabSpecificPermissions(

extension.get(), 0, permissions);

EXPECT_EQ(permissions->explicit_hosts(),

@@ -576,7 +577,8 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {

{

scoped_refptr<PermissionSet> permissions(

- new PermissionSet(APIPermissionSet(), allowed_hosts, URLPatternSet()));

+ new PermissionSet(APIPermissionSet(), ManifestPermissionSet(),

+ allowed_hosts, URLPatternSet()));

PermissionsData::UpdateTabSpecificPermissions(

extension.get(), 0, permissions);

EXPECT_EQ(permissions->explicit_hosts(),

@@ -584,6 +586,7 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {

->explicit_hosts());

permissions = new PermissionSet(APIPermissionSet(),

+ ManifestPermissionSet(),

more_allowed_hosts,

URLPatternSet());

PermissionsData::UpdateTabSpecificPermissions(