Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1818)

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test and clang presubmit errors. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/extensions/permissions_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_prefs_unittest.cc
diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc
index 511aeed482d208e03540b8da9e86c835bde4c1ae..3d1d24f1b13716030cd0ce4b8fef4d7b8cd8d9da 100644
--- a/chrome/browser/extensions/extension_prefs_unittest.cc
+++ b/chrome/browser/extensions/extension_prefs_unittest.cc
@@ -222,6 +222,7 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {
AddPattern(&shost_permissions_, "http://example.com/*");
APIPermissionSet empty_set;
+ ManifestPermissionSet empty_manifest_permissions;
URLPatternSet empty_extent;
scoped_refptr<PermissionSet> permissions;
scoped_refptr<PermissionSet> granted_permissions;
@@ -232,7 +233,7 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {
EXPECT_TRUE(granted_permissions->IsEmpty());
permissions = new PermissionSet(
- api_perm_set1_, empty_extent, empty_extent);
+ api_perm_set1_, empty_manifest_permissions, empty_extent, empty_extent);
// Add part of the api permissions.
prefs()->AddGrantedPermissions(extension_id_, permissions.get());
@@ -246,7 +247,7 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {
// Add part of the explicit host permissions.
permissions = new PermissionSet(
- empty_set, ehost_perm_set1_, empty_extent);
+ empty_set, empty_manifest_permissions, ehost_perm_set1_, empty_extent);
prefs()->AddGrantedPermissions(extension_id_, permissions.get());
granted_permissions = prefs()->GetGrantedPermissions(extension_id_);
EXPECT_FALSE(granted_permissions->IsEmpty());
@@ -259,7 +260,7 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {
// Add part of the scriptable host permissions.
permissions = new PermissionSet(
- empty_set, empty_extent, shost_perm_set1_);
+ empty_set, empty_manifest_permissions, empty_extent, shost_perm_set1_);
prefs()->AddGrantedPermissions(extension_id_, permissions.get());
granted_permissions = prefs()->GetGrantedPermissions(extension_id_);
EXPECT_FALSE(granted_permissions->IsEmpty());
@@ -276,7 +277,8 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {
// Add the rest of the permissions.
permissions = new PermissionSet(
- api_perm_set2_, ehost_perm_set2_, shost_perm_set2_);
+ api_perm_set2_, empty_manifest_permissions,
+ ehost_perm_set2_, shost_perm_set2_);
APIPermissionSet::Union(expected_apis, api_perm_set2_, &api_permissions_);
@@ -334,6 +336,8 @@ class ExtensionPrefsActivePermissions : public ExtensionPrefsTest {
api_perms.insert(APIPermission::kBookmark);
api_perms.insert(APIPermission::kHistory);
+ ManifestPermissionSet empty_manifest_permissions;
+
URLPatternSet ehosts;
AddPattern(&ehosts, "http://*.google.com/*");
AddPattern(&ehosts, "http://example.com/*");
@@ -343,7 +347,8 @@ class ExtensionPrefsActivePermissions : public ExtensionPrefsTest {
AddPattern(&shosts, "https://*.google.com/*");
AddPattern(&shosts, "http://reddit.com/r/test/*");
- active_perms_ = new PermissionSet(api_perms, ehosts, shosts);
+ active_perms_ = new PermissionSet(
+ api_perms, empty_manifest_permissions, ehosts, shosts);
// Make sure the active permissions start empty.
scoped_refptr<PermissionSet> active(
« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/extensions/permissions_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698