Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "chrome/browser/extensions/api/permissions/permissions_api_helpers.h" 7 #include "chrome/browser/extensions/api/permissions/permissions_api_helpers.h"
8 #include "chrome/common/extensions/api/permissions.h" 8 #include "chrome/common/extensions/api/permissions.h"
9 #include "extensions/common/permissions/permission_set.h" 9 #include "extensions/common/permissions/permission_set.h"
10 #include "extensions/common/url_pattern_set.h" 10 #include "extensions/common/url_pattern_set.h"
(...skipping 19 matching lines...) Expand all
30 TEST(ExtensionPermissionsAPIHelpers, Pack) { 30 TEST(ExtensionPermissionsAPIHelpers, Pack) {
31 APIPermissionSet apis; 31 APIPermissionSet apis;
32 apis.insert(APIPermission::kTab); 32 apis.insert(APIPermission::kTab);
33 apis.insert(APIPermission::kWebRequest); 33 apis.insert(APIPermission::kWebRequest);
34 // Note: kWebRequest implies also kWebRequestInternal. 34 // Note: kWebRequest implies also kWebRequestInternal.
35 URLPatternSet hosts; 35 URLPatternSet hosts;
36 AddPattern(&hosts, "http://a.com/*"); 36 AddPattern(&hosts, "http://a.com/*");
37 AddPattern(&hosts, "http://b.com/*"); 37 AddPattern(&hosts, "http://b.com/*");
38 38
39 scoped_refptr<PermissionSet> permission_set = 39 scoped_refptr<PermissionSet> permission_set =
40 new PermissionSet(apis, hosts, URLPatternSet()); 40 new PermissionSet(apis, ManifestPermissionSet(), hosts, URLPatternSet());
41 41
42 // Pack the permission set to value and verify its contents. 42 // Pack the permission set to value and verify its contents.
43 scoped_ptr<Permissions> permissions(PackPermissionSet(permission_set.get())); 43 scoped_ptr<Permissions> permissions(PackPermissionSet(permission_set.get()));
44 scoped_ptr<base::DictionaryValue> value(permissions->ToValue()); 44 scoped_ptr<base::DictionaryValue> value(permissions->ToValue());
45 base::ListValue* api_list = NULL; 45 base::ListValue* api_list = NULL;
46 base::ListValue* origin_list = NULL; 46 base::ListValue* origin_list = NULL;
47 EXPECT_TRUE(value->GetList("permissions", &api_list)); 47 EXPECT_TRUE(value->GetList("permissions", &api_list));
48 EXPECT_TRUE(value->GetList("origins", &origin_list)); 48 EXPECT_TRUE(value->GetList("origins", &origin_list));
49 49
50 EXPECT_EQ(3u, api_list->GetSize()); 50 EXPECT_EQ(3u, api_list->GetSize());
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 value->Set("permissions", invalid_apis->DeepCopy()); 166 value->Set("permissions", invalid_apis->DeepCopy());
167 EXPECT_TRUE(Permissions::Populate(*value, &permissions_object)); 167 EXPECT_TRUE(Permissions::Populate(*value, &permissions_object));
168 permissions = UnpackPermissionSet(permissions_object, true, &error); 168 permissions = UnpackPermissionSet(permissions_object, true, &error);
169 EXPECT_FALSE(permissions.get()); 169 EXPECT_FALSE(permissions.get());
170 EXPECT_FALSE(error.empty()); 170 EXPECT_FALSE(error.empty());
171 EXPECT_EQ(error, "'unknown_permission' is not a recognized permission."); 171 EXPECT_EQ(error, "'unknown_permission' is not a recognized permission.");
172 } 172 }
173 } 173 }
174 174
175 } // namespace extensions 175 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698