Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/common/extensions/permissions/permissions_data.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/permissions/permissions_data.h" 5 #include "chrome/common/extensions/permissions/permissions_data.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/common/extensions/extension.h" 14 #include "chrome/common/extensions/extension.h"
15 #include "chrome/common/extensions/extension_constants.h" 15 #include "chrome/common/extensions/extension_constants.h"
16 #include "content/public/common/url_constants.h" 16 #include "content/public/common/url_constants.h"
17 #include "extensions/common/constants.h" 17 #include "extensions/common/constants.h"
18 #include "extensions/common/error_utils.h" 18 #include "extensions/common/error_utils.h"
19 #include "extensions/common/extensions_client.h" 19 #include "extensions/common/extensions_client.h"
20 #include "extensions/common/features/feature.h" 20 #include "extensions/common/features/feature.h"
21 #include "extensions/common/features/feature_provider.h" 21 #include "extensions/common/features/feature_provider.h"
22 #include "extensions/common/manifest.h" 22 #include "extensions/common/manifest.h"
23 #include "extensions/common/manifest_constants.h" 23 #include "extensions/common/manifest_constants.h"
24 #include "extensions/common/manifest_constants.h" 24 #include "extensions/common/manifest_handler.h"
25 #include "extensions/common/permissions/api_permission_set.h" 25 #include "extensions/common/permissions/api_permission_set.h"
26 #include "extensions/common/permissions/permission_message_provider.h" 26 #include "extensions/common/permissions/permission_message_provider.h"
27 #include "extensions/common/permissions/permission_set.h" 27 #include "extensions/common/permissions/permission_set.h"
28 #include "extensions/common/permissions/permissions_info.h" 28 #include "extensions/common/permissions/permissions_info.h"
29 #include "extensions/common/switches.h" 29 #include "extensions/common/switches.h"
30 #include "extensions/common/url_pattern_set.h" 30 #include "extensions/common/url_pattern_set.h"
31 #include "extensions/common/user_script.h" 31 #include "extensions/common/user_script.h"
32 #include "url/gurl.h" 32 #include "url/gurl.h"
33 33
34 namespace extensions { 34 namespace extensions {
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 // Returns true if this extension id is from a trusted provider. 239 // Returns true if this extension id is from a trusted provider.
240 bool IsTrustedId(const std::string& extension_id) { 240 bool IsTrustedId(const std::string& extension_id) {
241 // See http://b/4946060 for more details. 241 // See http://b/4946060 for more details.
242 return extension_id == std::string("nckgahadagoaajjgafhacjanaoiihapd"); 242 return extension_id == std::string("nckgahadagoaajjgafhacjanaoiihapd");
243 } 243 }
244 244
245 } // namespace 245 } // namespace
246 246
247 struct PermissionsData::InitialPermissions { 247 struct PermissionsData::InitialPermissions {
248 APIPermissionSet api_permissions; 248 APIPermissionSet api_permissions;
249 ManifestPermissionSet manifest_permissions;
249 URLPatternSet host_permissions; 250 URLPatternSet host_permissions;
250 URLPatternSet scriptable_hosts; 251 URLPatternSet scriptable_hosts;
251 }; 252 };
252 253
253 PermissionsData::PermissionsData() { 254 PermissionsData::PermissionsData() {
254 } 255 }
255 256
256 PermissionsData::~PermissionsData() { 257 PermissionsData::~PermissionsData() {
257 } 258 }
258 259
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 keys::kOptionalPermissions, 598 keys::kOptionalPermissions,
598 &initial_optional_permissions_->api_permissions, 599 &initial_optional_permissions_->api_permissions,
599 &initial_optional_permissions_->host_permissions, 600 &initial_optional_permissions_->host_permissions,
600 error)) { 601 error)) {
601 return false; 602 return false;
602 } 603 }
603 604
604 return true; 605 return true;
605 } 606 }
606 607
608 void PermissionsData::InitializeManifestPermissions(Extension* extension) {
609 ManifestHandler::AddExtensionRequiredPermissions(
610 extension, &initial_required_permissions_->manifest_permissions);
611 }
612
607 void PermissionsData::FinalizePermissions(Extension* extension) { 613 void PermissionsData::FinalizePermissions(Extension* extension) {
608 active_permissions_ = new PermissionSet( 614 active_permissions_ = new PermissionSet(
609 initial_required_permissions_->api_permissions, 615 initial_required_permissions_->api_permissions,
616 initial_required_permissions_->manifest_permissions,
610 initial_required_permissions_->host_permissions, 617 initial_required_permissions_->host_permissions,
611 initial_required_permissions_->scriptable_hosts); 618 initial_required_permissions_->scriptable_hosts);
612 619
613 required_permission_set_ = new PermissionSet( 620 required_permission_set_ = new PermissionSet(
614 initial_required_permissions_->api_permissions, 621 initial_required_permissions_->api_permissions,
622 initial_required_permissions_->manifest_permissions,
615 initial_required_permissions_->host_permissions, 623 initial_required_permissions_->host_permissions,
616 initial_required_permissions_->scriptable_hosts); 624 initial_required_permissions_->scriptable_hosts);
617 625
618 optional_permission_set_ = new PermissionSet( 626 optional_permission_set_ = new PermissionSet(
619 initial_optional_permissions_->api_permissions, 627 initial_optional_permissions_->api_permissions,
628 initial_optional_permissions_->manifest_permissions,
620 initial_optional_permissions_->host_permissions, 629 initial_optional_permissions_->host_permissions,
621 URLPatternSet()); 630 URLPatternSet());
622 631
623 initial_required_permissions_.reset(); 632 initial_required_permissions_.reset();
624 initial_optional_permissions_.reset(); 633 initial_optional_permissions_.reset();
625 } 634 }
626 635
627 } // namespace extensions 636 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698