Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: extensions/common/manifest_handler.h

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review feedback. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLER_H_ 5 #ifndef EXTENSIONS_COMMON_MANIFEST_HANDLER_H_
6 #define EXTENSIONS_COMMON_MANIFEST_HANDLER_H_ 6 #define EXTENSIONS_COMMON_MANIFEST_HANDLER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/lazy_instance.h" 12 #include "base/lazy_instance.h"
13 #include "base/memory/linked_ptr.h" 13 #include "base/memory/linked_ptr.h"
14 #include "base/strings/string16.h" 14 #include "base/strings/string16.h"
15 #include "extensions/common/manifest.h" 15 #include "extensions/common/manifest.h"
16 16
17 namespace extensions { 17 namespace extensions {
18 class Extension; 18 class Extension;
19 class ManifestPermission;
20 class ManifestPermissionSet;
19 21
20 // An interface for clients that recognize and parse keys in extension 22 // An interface for clients that recognize and parse keys in extension
21 // manifests. 23 // manifests.
22 class ManifestHandler { 24 class ManifestHandler {
23 public: 25 public:
24 ManifestHandler(); 26 ManifestHandler();
25 virtual ~ManifestHandler(); 27 virtual ~ManifestHandler();
26 28
27 // Attempts to parse the extension's manifest. 29 // Attempts to parse the extension's manifest.
28 // Returns true on success or false on failure; if false, |error| will 30 // Returns true on success or false on failure; if false, |error| will
(...skipping 28 matching lines...) Expand all
57 virtual const std::vector<std::string> PrerequisiteKeys() const; 59 virtual const std::vector<std::string> PrerequisiteKeys() const;
58 60
59 // Associate us with our keys() in the manifest. A handler can register 61 // Associate us with our keys() in the manifest. A handler can register
60 // for multiple keys. The global registry takes ownership of this; 62 // for multiple keys. The global registry takes ownership of this;
61 // if it has an existing handler for |key|, it replaces it with this. 63 // if it has an existing handler for |key|, it replaces it with this.
62 // Manifest handlers must be registered at process startup in 64 // Manifest handlers must be registered at process startup in
63 // chrome_manifest_handlers.cc: 65 // chrome_manifest_handlers.cc:
64 // (new MyManifestHandler)->Register(); 66 // (new MyManifestHandler)->Register();
65 void Register(); 67 void Register();
66 68
69 // Creates a |ManifestPermission| instance for the given manifest key |name|.
70 // The returned permission does not contain any permission data, so this
71 // method is usually used before calling |FromValue| or |Read|. Returns
72 // |NULL| if the manifest handler does not support custom permissions.
73 virtual ManifestPermission* CreatePermission();
74
75 // Creates a |ManifestPermission| instance containing the initial set of
76 // required manifest permissions for the given |extension|.
77 virtual ManifestPermission* CreateInitialRequiredPermission(
78 const Extension* extension);
79
67 // Calling FinalizeRegistration indicates that there are no more 80 // Calling FinalizeRegistration indicates that there are no more
68 // manifest handlers to be registered. 81 // manifest handlers to be registered.
69 static void FinalizeRegistration(); 82 static void FinalizeRegistration();
70 83
71 static bool IsRegistrationFinalized(); 84 static bool IsRegistrationFinalized();
72 85
73 // Call Parse on all registered manifest handlers that should parse 86 // Call Parse on all registered manifest handlers that should parse
74 // this extension. 87 // this extension.
75 static bool ParseExtension(Extension* extension, string16* error); 88 static bool ParseExtension(Extension* extension, string16* error);
76 89
77 // Call Validate on all registered manifest handlers for this extension. 90 // Call Validate on all registered manifest handlers for this extension.
78 static bool ValidateExtension(const Extension* extension, 91 static bool ValidateExtension(const Extension* extension,
79 std::string* error, 92 std::string* error,
80 std::vector<InstallWarning>* warnings); 93 std::vector<InstallWarning>* warnings);
81 94
95 // Calls |CreatePermission| on the manifest handler for |key|. Returns |NULL|
96 // if there is no manifest handler for |key| or if the manifest handler for
97 // |key| does not support custom permissions.
98 static ManifestPermission* CreatePermission(const std::string& key);
99
100 // Calls |CreateInitialRequiredPermission| on all registered manifest handlers
101 // and adds the returned permissions to |permission_set|. Note this should be
102 // called after all manifest data elements have been read, parsed and stored
103 // in the manifest data property of |extension|, as manifest handlers need
104 // access to their manifest data to initialize their required manifest
105 // permission.
106 static void AddExtensionInitialRequiredPermissions(
107 const Extension* extension, ManifestPermissionSet* permission_set);
108
82 protected: 109 protected:
83 // A convenience method for handlers that only register for 1 key, 110 // A convenience method for handlers that only register for 1 key,
84 // so that they can define keys() { return SingleKey(kKey); } 111 // so that they can define keys() { return SingleKey(kKey); }
85 static const std::vector<std::string> SingleKey(const std::string& key); 112 static const std::vector<std::string> SingleKey(const std::string& key);
86 113
87 private: 114 private:
88 // The keys to register us for (in Register). 115 // The keys to register us for (in Register).
89 virtual const std::vector<std::string> Keys() const = 0; 116 virtual const std::vector<std::string> Keys() const = 0;
90 }; 117 };
91 118
92 // The global registry for manifest handlers. 119 // The global registry for manifest handlers.
93 class ManifestHandlerRegistry { 120 class ManifestHandlerRegistry {
94 private: 121 private:
95 friend class ManifestHandler; 122 friend class ManifestHandler;
96 friend class ScopedTestingManifestHandlerRegistry; 123 friend class ScopedTestingManifestHandlerRegistry;
97 friend struct base::DefaultLazyInstanceTraits<ManifestHandlerRegistry>; 124 friend struct base::DefaultLazyInstanceTraits<ManifestHandlerRegistry>;
98 125
99 ManifestHandlerRegistry(); 126 ManifestHandlerRegistry();
100 ~ManifestHandlerRegistry(); 127 ~ManifestHandlerRegistry();
101 128
102 void Finalize(); 129 void Finalize();
103 130
104 void RegisterManifestHandler(const std::string& key, 131 void RegisterManifestHandler(const std::string& key,
105 linked_ptr<ManifestHandler> handler); 132 linked_ptr<ManifestHandler> handler);
106 bool ParseExtension(Extension* extension, string16* error); 133 bool ParseExtension(Extension* extension, string16* error);
107 bool ValidateExtension(const Extension* extension, 134 bool ValidateExtension(const Extension* extension,
108 std::string* error, 135 std::string* error,
109 std::vector<InstallWarning>* warnings); 136 std::vector<InstallWarning>* warnings);
110 137
138 ManifestPermission* CreatePermission(const std::string& key);
139
140 void AddExtensionInitialRequiredPermissions(
141 const Extension* extension,
142 ManifestPermissionSet* permission_set);
143
111 // Overrides the current global ManifestHandlerRegistry with 144 // Overrides the current global ManifestHandlerRegistry with
112 // |registry|, returning the current one. 145 // |registry|, returning the current one.
113 static ManifestHandlerRegistry* SetForTesting( 146 static ManifestHandlerRegistry* SetForTesting(
114 ManifestHandlerRegistry* new_registry); 147 ManifestHandlerRegistry* new_registry);
115 148
116 typedef std::map<std::string, linked_ptr<ManifestHandler> > 149 typedef std::map<std::string, linked_ptr<ManifestHandler> >
117 ManifestHandlerMap; 150 ManifestHandlerMap;
118 typedef std::map<ManifestHandler*, int> ManifestHandlerPriorityMap; 151 typedef std::map<ManifestHandler*, int> ManifestHandlerPriorityMap;
119 152
120 // Puts the manifest handlers in order such that each handler comes after 153 // Puts the manifest handlers in order such that each handler comes after
121 // any handlers for their PrerequisiteKeys. If there is no handler for 154 // any handlers for their PrerequisiteKeys. If there is no handler for
122 // a prerequisite key, that dependency is simply ignored. 155 // a prerequisite key, that dependency is simply ignored.
123 // CHECKs that there are no manifest handlers with circular dependencies. 156 // CHECKs that there are no manifest handlers with circular dependencies.
124 void SortManifestHandlers(); 157 void SortManifestHandlers();
125 158
126 // All registered manifest handlers. 159 // All registered manifest handlers.
127 ManifestHandlerMap handlers_; 160 ManifestHandlerMap handlers_;
128 161
129 // The priority for each manifest handler. Handlers with lower priority 162 // The priority for each manifest handler. Handlers with lower priority
130 // values are evaluated first. 163 // values are evaluated first.
131 ManifestHandlerPriorityMap priority_map_; 164 ManifestHandlerPriorityMap priority_map_;
132 165
133 bool is_finalized_; 166 bool is_finalized_;
134 }; 167 };
135 168
136 } // namespace extensions 169 } // namespace extensions
137 170
138 #endif // EXTENSIONS_COMMON_MANIFEST_HANDLER_H_ 171 #endif // EXTENSIONS_COMMON_MANIFEST_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698