Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/common/extensions/api/sockets/sockets_manifest_permission_unittest.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review feedback. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/pickle.h"
6 #include "base/values.h"
7 #include "chrome/common/extensions/api/sockets/sockets_manifest_permission.h"
8 #include "chrome/common/extensions/extension_messages.h"
9 #include "extensions/common/manifest_constants.h"
10 #include "ipc/ipc_message.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 namespace extensions {
14
15 namespace {
16
17 static void AssertEmptyPermission(SocketsManifestPermission* permission) {
18 EXPECT_TRUE(permission);
19 EXPECT_EQ(std::string(extensions::manifest_keys::kSockets), permission->id());
20 EXPECT_EQ(permission->id(), permission->name());
21 EXPECT_EQ(false, permission->HasMessages());
22 }
23
24 } // namespace
25
26 TEST(SocketsManifestPermissionTest, Empty) {
27 // Construction
28 scoped_ptr<SocketsManifestPermission> permission(
29 new SocketsManifestPermission());
30 AssertEmptyPermission(permission.get());
31
32 // Clone()/Equal()
33 scoped_ptr<SocketsManifestPermission> clone(
34 static_cast<SocketsManifestPermission*>(permission->Clone()));
35 AssertEmptyPermission(clone.get());
36
37 EXPECT_TRUE(permission->Equal(clone.get()));
38
39 // ToValue()/FromValue()
40 scoped_ptr<const base::Value> value(permission->ToValue());
41 EXPECT_TRUE(value.get());
42
43 scoped_ptr<SocketsManifestPermission> permission2(
44 new SocketsManifestPermission());
45 EXPECT_TRUE(permission2->FromValue(value.get()));
46 AssertEmptyPermission(permission2.get());
47
48 // Union/Diff/Intersection
49 scoped_ptr<SocketsManifestPermission> diff_perm(
50 static_cast<SocketsManifestPermission*>(permission->Diff(clone.get())));
51 AssertEmptyPermission(diff_perm.get());
52
53 scoped_ptr<SocketsManifestPermission> union_perm(
54 static_cast<SocketsManifestPermission*>(permission->Union(clone.get())));
55 AssertEmptyPermission(union_perm.get());
56
57 scoped_ptr<SocketsManifestPermission> intersect_perm(
58 static_cast<SocketsManifestPermission*>(
59 permission->Intersect(clone.get())));
60 AssertEmptyPermission(intersect_perm.get());
61
62 // IPC
63 scoped_ptr<SocketsManifestPermission> ipc_perm(
64 new SocketsManifestPermission());
65 scoped_ptr<SocketsManifestPermission> ipc_perm2(
66 new SocketsManifestPermission());
67
68 IPC::Message m;
69 ipc_perm->Write(&m);
70 PickleIterator iter(m);
71 EXPECT_TRUE(ipc_perm2->Read(&m, &iter));
72 AssertEmptyPermission(ipc_perm2.get());
73 }
74
75 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698