mojo/public/tools/bindings/pylib/mojom/generate/module.py - Issue 514293002: Mojo: validate nullability in Java bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/module.py

Issue 514293002: Mojo: validate nullability in Java bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add example Foo.java. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/pylib/mojom/generate/module.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/module.py b/mojo/public/tools/bindings/pylib/mojom/generate/module.py

index b73c93766d56469e2644df7b9c8fbe46f3832d12..dd5ece9c1d2978a913685f53594a2c862b55641e 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/module.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/module.py

@@ -377,8 +377,12 @@ def IsEnumKind(kind):

return isinstance(kind, Enum)

+def IsReferenceKind(kind):

+ return isinstance(kind, ReferenceKind)

def IsNullableKind(kind):

- return isinstance(kind, ReferenceKind) and kind.is_nullable

+ return IsReferenceKind(kind) and kind.is_nullable

def IsAnyArrayKind(kind):