Generate externs automatically from json/idl files: minor changes.

Generate externs automatically from json/idl files: minor changes. 

Continued from https://codereview.chromium.org/15677003/
New:
- remove trailing comma in typedef
- add "var " before types
- generate namespace object
- translate "events"

R=tbreisacher@chromium.org
TEST=tools/json_schema_compiler/compiler.py chrome/common/extensions/api/bookmark_manager_private.json --root=~/src/ --generator=externs

[hirono, 2014-10-03 10:10:42]

hirono@chromium.org changed reviewers:
+ hirono@chromium.org

[hirono, 2014-10-03 10:10:43]

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/j...
File tools/json_schema_compiler/js_externs_generator.py (right):

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/j...
tools/json_schema_compiler/js_externs_generator.py:1: # Copyright (c) 2013 The
Chromium Authors. All rights reserved.
nit: 2014?

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/j...
tools/json_schema_compiler/js_externs_generator.py:70: c.Append('var ' +
type_.simple_name + ' = function();')
Is it OK dropping arguments of constructor?

[Vitaly Pavlenko, 2014-10-03 23:33:44]

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/j...
File tools/json_schema_compiler/js_externs_generator.py (right):

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/j...
tools/json_schema_compiler/js_externs_generator.py:70: c.Append('var ' +
type_.simple_name + ' = function();')
On 2014/10/03 10:10:42, hirono wrote:
> Is it OK dropping arguments of constructor?

You're right, that's a mistake. By the way, will your team publish the next
version of this CL based on your externs generation from idl?

[hirono, 2014-10-06 10:34:06]

Sorry, I commented to the CL unintentionally. And yes. @fukino is working on
crrev.com/625813003.

[hirono, 2014-10-24 04:36:02]

hirono@chromium.org changed reviewers:
- tbreisacher@chromium.org

[hirono, 2014-10-24 04:36:43]

hirono@chromium.org changed reviewers:
- hirono@chromium.org

[hirono, 2014-10-24 04:38:24]

hirono@chromium.org changed reviewers:
+ tbreisacher@chromium.org

[Dan Beam, 2015-02-24 23:46:13]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-02-24 23:46:14]

what's holding up this review?  can we check this script in somewhere if we're
already using it to generate externs?

[Tyler Breisacher (Chromium), 2015-02-24 23:48:11]

On 2015/02/24 23:46:14, Dan Beam wrote:
> what's holding up this review?  can we check this script in somewhere if we're
> already using it to generate externs?

If someone is already using this to generate externs, and using those externs, I
agree, let's check it in as is (marking it as experimental/in-progress/whatever
if necessary). I don't know if anyone is doing that though.

[Dan Beam, 2015-02-24 23:53:14]

On 2015/02/24 23:48:11, Tyler Breisacher (Chromium) wrote:
> On 2015/02/24 23:46:14, Dan Beam wrote:
> > what's holding up this review?  can we check this script in somewhere if
we're
> > already using it to generate externs?
> 
> If someone is already using this to generate externs, and using those externs,
I
> agree, let's check it in as is (marking it as
experimental/in-progress/whatever
> if necessary). I don't know if anyone is doing that though.

see:
third_party/closure_compiler/externs/*private.js
https://codereview.chromium.org/625813003
https://codereview.chromium.org/543863002

[Tyler Breisacher (Chromium), 2015-02-25 00:17:24]

Okay then yeah it should probably be checked in.

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/c...
File tools/json_schema_compiler/create_externs.sh (right):

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/c...
tools/json_schema_compiler/create_externs.sh:12: # Just printing to stdout for
now
Let's remove this and just make it part of the official docs at the top

#!/bin/bash
#
# Reads the IDL files from chrome/common/extensions/api/ and
# writes JS externs for the Closure Compiler to stdout.

[Tyler Breisacher (Chromium), 2015-02-25 00:22:05]

Actually it would be cool to check this in, delete the generated externs, and
set up the build so that the generated externs from this script are used
automatically.

Anyway lgtm. Didn't know this was actually being used. That's kind of awesome :)

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/j...
File tools/json_schema_compiler/js_externs_generator.py (right):

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/j...
tools/json_schema_compiler/js_externs_generator.py:122: codeString =
'\n'.join(lines)
Can probably inline this?

codeString = '\n'.join(' * ' + line for line in lines)

(and it should be code_string IIRC)

https://codereview.chromium.org/511943003/diff/1/tools/json_schema_compiler/j...
tools/json_schema_compiler/js_externs_generator.py:182: return '?' # TODO make
this more specific
put someone's name on this TODO. I reluctantly volunteer mine if no one else
wants to own it.

[Tyler Breisacher (Chromium), 2015-03-30 21:11:32]

tbreisacher@chromium.org changed reviewers:
- dbeam@chromium.org, tbreisacher@chromium.org