Chromium Code Reviews
Help | Chromium Project | Sign in
(29)

Issue 50433010: WebUI fixes for SDK 0.8.10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 5 months ago
Reviewers:
dgrove, John Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

WebUI fixes for SDK 0.8.10 Committed: https://github.com/dart-lang/web-ui/commit/b771435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -28 lines) Patch
M lib/observe/list.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M lib/observe/set.dart View 2 chunks +1 line, -3 lines 0 comments Download
M lib/src/html5_setters.g.dart View 10 chunks +0 lines, -13 lines 0 comments Download
M lib/src/utils_observe.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
tbr - note the changes to html5_setters.g.dart was done by hand (the script is busted ...
1 year, 5 months ago (2013-11-02 01:21:46 UTC) #1
Siggi Cherem (dart-lang)
Committed patchset #1 manually as rb771435 (presubmit successful).
1 year, 5 months ago (2013-11-02 01:22:05 UTC) #2
John Messerly
1 year, 5 months ago (2013-11-04 18:04:04 UTC) #3
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771