content/browser/service_worker/service_worker_job_coordinator.cc - Issue 501453002: Decouple script_url from ServiceWorkerRegistration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_coordinator.cc

Issue 501453002: Decouple script_url from ServiceWorkerRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync after major collision Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_job_coordinator.cc

diff --git a/content/browser/service_worker/service_worker_job_coordinator.cc b/content/browser/service_worker/service_worker_job_coordinator.cc

index 13e4b4b703ca28e5a47cdaddac99a1a5bb869b78..e5e89620e86769b8fd03890ca49753d993b89380 100644

--- a/content/browser/service_worker/service_worker_job_coordinator.cc

+++ b/content/browser/service_worker/service_worker_job_coordinator.cc

@@ -94,6 +94,8 @@ void ServiceWorkerJobCoordinator::Unregister(

void ServiceWorkerJobCoordinator::Update(

ServiceWorkerRegistration* registration) {

+ DCHECK(registration);

+ DCHECK(registration->GetNewestVersion());

job_queues_[registration->pattern()].Push(

make_scoped_ptr<ServiceWorkerRegisterJobBase>(

new ServiceWorkerRegisterJob(context_, registration)));