content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 501453002: Decouple script_url from ServiceWorkerRegistration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 501453002: Decouple script_url from ServiceWorkerRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments and add unittests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_register_job.cc ('K') | « content/browser/service_worker/service_worker_storage_unittest.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index b0c4699523d9b454fb44f993ac17fc25b5d66eed..dc5215079ccd9826369800819224ef99ee513e3b 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -101,11 +101,13 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

registration_ = new ServiceWorkerRegistration(

GURL("http://example.com/"),

- GURL("http://example.com/service_worker.js"),

1L,

helper_->context()->AsWeakPtr());

version_ = new ServiceWorkerVersion(

- registration_, 1L, helper_->context()->AsWeakPtr());

+ registration_,

+ GURL("http://example.com/service_worker.js"),

+ 1L,

+ helper_->context()->AsWeakPtr());

scoped_ptr<ServiceWorkerProviderHost> provider_host(

new ServiceWorkerProviderHost(