content/browser/service_worker/service_worker_handle.cc - Issue 501453002: Decouple script_url from ServiceWorkerRegistration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_handle.cc

Issue 501453002: Decouple script_url from ServiceWorkerRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments and add unittests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_handle.cc

diff --git a/content/browser/service_worker/service_worker_handle.cc b/content/browser/service_worker/service_worker_handle.cc

index 69d6c48e93c610c18d19aa3101b26dfd50d6152b..1adab523726e3a60c3cc4ba497424a18015ea8e9 100644

--- a/content/browser/service_worker/service_worker_handle.cc

+++ b/content/browser/service_worker/service_worker_handle.cc

@@ -110,7 +110,7 @@ ServiceWorkerObjectInfo ServiceWorkerHandle::GetObjectInfo() {

ServiceWorkerObjectInfo info;

info.handle_id = handle_id_;

info.scope = registration_->pattern();

- info.url = registration_->script_url();

+ info.url = version_->script_url();

info.state = GetWebServiceWorkerState(version_);

return info;

}