content/browser/service_worker/service_worker_context_request_handler_unittest.cc - Issue 501453002: Decouple script_url from ServiceWorkerRegistration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

Issue 501453002: Decouple script_url from ServiceWorkerRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments and add unittests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_context_wrapper.cc » ('j') | content/browser/service_worker/service_worker_register_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

index ab37a38b57ed4993541ccffcb3d78b60d4bdeae0..7d8b9886c66d60037684901aa7828a3775389d0f 100644

--- a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

@@ -41,10 +41,9 @@ class ServiceWorkerContextRequestHandlerTest : public testing::Test {

scope_ = GURL("http://host/scope/");

script_url_ = GURL("http://host/script.js");

registration_ = new ServiceWorkerRegistration(

- scope_, script_url_, 1L, context()->AsWeakPtr());

+ scope_, 1L, context()->AsWeakPtr());

version_ = new ServiceWorkerVersion(

- registration_,

- 1L, context()->AsWeakPtr());

+ registration_, script_url_, 1L, context()->AsWeakPtr());

// An empty host.

scoped_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(