content/browser/resources/service_worker/serviceworker_internals.html - Issue 501453002: Decouple script_url from ServiceWorkerRegistration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/resources/service_worker/serviceworker_internals.html

Issue 501453002: Decouple script_url from ServiceWorkerRegistration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments and add unittests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/resources/service_worker/serviceworker_internals.js » ('j') | content/browser/service_worker/service_worker_register_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/resources/service_worker/serviceworker_internals.html

diff --git a/content/browser/resources/service_worker/serviceworker_internals.html b/content/browser/resources/service_worker/serviceworker_internals.html

index 913811a2f9cfe0538532fdcfcd3e02cdb4a77d54..9f0a6b5b4cd498b003ba0fe9ec657fc93b53b97c 100644

--- a/content/browser/resources/service_worker/serviceworker_internals.html

+++ b/content/browser/resources/service_worker/serviceworker_internals.html

@@ -19,6 +19,10 @@

<span>Running Status:</span>

</div>

+ <div class="serviceworker-script_url">

+ <span>Script:</span>

+ <span jscontent="$this.script_url"></span>

+ </div>

<span>Version ID:</span>

@@ -63,10 +67,6 @@

<span>Scope:</span>

</div>

- <div class="serviceworker-script_url">

- <span>Script:</span>

- <span jscontent="script_url"></span>

- </div>

<span>Registration ID:</span>