ui/ios/NSString+CrStringDrawing.mm - Issue 497503004: Add NSString category for providing iOS6-style string drawing APIs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/ios/NSString+CrStringDrawing.mm

Issue 497503004: Add NSString category for providing iOS6-style string drawing APIs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: TIL export_dependent_settings Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import "ui/ios/NSString+CrStringDrawing.h"

	6

	7 @implementation NSString (CrStringDrawing)

	8

	9 - (CGSize)cr_sizeWithFont:(UIFont*)font {

	10 if (!font)

	11 return CGSizeZero;

	12 NSDictionary* attributes = @{ NSFontAttributeName : font };

	13 CGSize sizeWithAttributes = [self sizeWithAttributes:attributes];

	14 return CGSizeMake(ceil(sizeWithAttributes.width),

	15 ceil(sizeWithAttributes.height));
	stuartmorgan 2014/08/25 20:17:37 Do we actually want the ceil? That's just to exact Do we actually want the ceil? That's just to exactly match the behavior of the old API it seems like, which is different from just providing a similar structure of API. lliabraa 2014/08/28 12:13:20 I've split this into two methods. One is a drop-in Show quoted text On 2014/08/25 20:17:37, stuartmorgan wrote: > Do we actually want the ceil? That's just to exactly match the behavior of the > old API it seems like, which is different from just providing a similar > structure of API. I've split this into two methods. One is a drop-in replacement for sizeWithFont (nil-checking, rounding); the other is a convenience wrapper to avoid the boilerplate of the attributes dictionary (DCHECK on nill font and no rounding).
	16 }

	17

	18 @end

OLD	NEW