Make iossim binary work on Xcode 5 and 6.

Make iossim binary work on Xcode 5 and 6.

The CL changes most compile-time checks to be runtime-checks so that
an iossim binary built agains Xcode 6 will still work against Xcode 5.

BUG=None

Committed: https://crrev.com/7f590bcff76926fc8442e020dcd1eebf604bf129
Cr-Commit-Position: refs/heads/master@{#291681}

[TVL, 2014-08-21 19:41:50]

https://codereview.chromium.org/494583004/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://codereview.chromium.org/494583004/diff/1/testing/iossim/iossim.mm#new...
testing/iossim/iossim.mm:46: #endif  // IOSSIM_USE_XCODE_6
I'm guessing these need to be cleaned up or this won't build with Xcode 5?  Do
you also want to stop passing the define in from the gyp file?

https://codereview.chromium.org/494583004/diff/1/testing/iossim/iossim.mm#new...
testing/iossim/iossim.mm:168: NSTask* xcodeSelectTask = [[[NSTask alloc] init]
autorelease];
fyi - you could probably make a common method with the xcode-select one below to
run and collect the output and then just have the processing in both.

https://codereview.chromium.org/494583004/diff/1/testing/iossim/iossim.mm#new...
testing/iossim/iossim.mm:182: encoding:NSUTF8StringEncoding] autorelease];
fyi - another options is NSScanner, can the "Xcode", then ask it to read the
next string.  Then you only really need the first line not to change format.

https://codereview.chromium.org/494583004/diff/1/testing/iossim/iossim.mm#new...
testing/iossim/iossim.mm:222: printf("Supported SDK versions:\n");
maybe a comment that this the the list from Xcode 5.1.x?

https://codereview.chromium.org/494583004/diff/1/testing/iossim/iossim.mm#new...
testing/iossim/iossim.mm:227: printf("Supported devices:\n");
maybe a comment that this the the list from Xcode 5.1.x?

[lliabraa, 2014-08-22 17:50:56]

Thanks for the review!

I've verified that iossim can build with Xcode 5 or 6 active. I've also verified
that the binary build with Xcode 6 can successfully run an app with Xcode 5
active.

PTAL

https://chromiumcodereview.appspot.com/494583004/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/494583004/diff/1/testing/iossim/iossim...
testing/iossim/iossim.mm:46: #endif  // IOSSIM_USE_XCODE_6
On 2014/08/21 19:41:50, TVL wrote:
> I'm guessing these need to be cleaned up or this won't build with Xcode 5?
I've added compile-time checks around all the xcode6-only code, so the iossim
target will compile with xcode 5.

> Do you also want to stop passing the define in from the gyp file?
I still need the define so I know whether or not to import CoreSimulator.h

https://chromiumcodereview.appspot.com/494583004/diff/1/testing/iossim/iossim...
testing/iossim/iossim.mm:182: encoding:NSUTF8StringEncoding] autorelease];
On 2014/08/21 19:41:50, TVL wrote:
> fyi - another options is NSScanner, can the "Xcode", then ask it to read the
> next string.  Then you only really need the first line not to change format.

Done.

https://chromiumcodereview.appspot.com/494583004/diff/1/testing/iossim/iossim...
testing/iossim/iossim.mm:222: printf("Supported SDK versions:\n");
On 2014/08/21 19:41:50, TVL wrote:
> maybe a comment that this the the list from Xcode 5.1.x?

Makes sense for the hard-coded list of devices, but the list of SDKs is
dynamically provided by whatever version of xcode is installed.

https://chromiumcodereview.appspot.com/494583004/diff/1/testing/iossim/iossim...
testing/iossim/iossim.mm:227: printf("Supported devices:\n");
On 2014/08/21 19:41:50, TVL wrote:
> maybe a comment that this the the list from Xcode 5.1.x?

Done.

[TVL, 2014-08-22 18:27:36]

Or find a good choke point very early in mail to error out if built without
xcode 6 support and running under xcode 6

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
File testing/iossim/iossim.gyp (right):

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.gyp:33: 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
if you want a smaller hammer, can you wrap the import with something like:

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wwhat_ever_it_is"
#import "header.h"
#pragma clang diagnostic pop

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:163: NSString* GetOutputFromTask(NSTask* task) {
take

NSString *toolPath, NSArray *args

and you can shrink the code a little more.  :)

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:170: [task terminate];
optional - check exit code?

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:230: #endif  // IOSSIM_USE_XCODE_6
#else
error out since support is missing?
#endif

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:315: #endif  // IOSSIM_USE_XCODE_6
#else
error out since support is missing?
#endif

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:471: #endif  // IOSSIM_USE_XCODE_6
#else
error out since support is missing?
#endif

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:684: #endif  // IOSSIM_USE_XCODE_6
#else
error out since support is missing?
#endif

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:932: #endif  // IOSSIM_USE_XCODE_6
#else
error out since support is missing?
#endif

[lliabraa, 2014-08-25 13:14:04]

I added a method at the beginning of main to ensure support for the current
Xcode version.

I was unable to reduce the size of the -Werror hammer. Let me know if you have
any ideas.

Thanks for the review.

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
File testing/iossim/iossim.gyp (right):

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.gyp:33: 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
On 2014/08/22 18:27:35, TVL wrote:
> if you want a smaller hammer, can you wrap the import with something like:
> 
> #pragma clang diagnostic push
> #pragma clang diagnostic ignored "-Wwhat_ever_it_is"
> #import "header.h"
> #pragma clang diagnostic pop
> 

I can't find the -W flag for this warning; I think it may be new and
uncategorized? The compiler output is:

error: type of property 'name' does not match type of accessor 'setName:'

and there is no [-Wname_of_warning_flag] at the end to tell me how to turn it
off.

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:163: NSString* GetOutputFromTask(NSTask* task) {
On 2014/08/22 18:27:36, TVL wrote:
> take
> 
> NSString *toolPath, NSArray *args
> 
> and you can shrink the code a little more.  :)

Done.

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:170: [task terminate];
On 2014/08/22 18:27:35, TVL wrote:
> optional - check exit code?

Done.

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:230: #endif  // IOSSIM_USE_XCODE_6
On 2014/08/22 18:27:36, TVL wrote:
> #else
> error out since support is missing?
> #endif

Acknowledged.

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:315: #endif  // IOSSIM_USE_XCODE_6
On 2014/08/22 18:27:36, TVL wrote:
> #else
> error out since support is missing?
> #endif

Acknowledged.

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:471: #endif  // IOSSIM_USE_XCODE_6
On 2014/08/22 18:27:36, TVL wrote:
> #else
> error out since support is missing?
> #endif

Acknowledged.

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:684: #endif  // IOSSIM_USE_XCODE_6
On 2014/08/22 18:27:36, TVL wrote:
> #else
> error out since support is missing?
> #endif

Acknowledged.

https://chromiumcodereview.appspot.com/494583004/diff/40001/testing/iossim/io...
testing/iossim/iossim.mm:932: #endif  // IOSSIM_USE_XCODE_6
On 2014/08/22 18:27:35, TVL wrote:
> #else
> error out since support is missing?
> #endif

Acknowledged.

[TVL, 2014-08-25 13:19:03]

lgtm

lg with the pool created before the version check.

https://chromiumcodereview.appspot.com/494583004/diff/60001/testing/iossim/io...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/494583004/diff/60001/testing/iossim/io...
testing/iossim/iossim.mm:182: LogError(@"Task '%@ %@' exited with return code
%@.",
isn't terminationStatus an int?  (you are using %@)

https://chromiumcodereview.appspot.com/494583004/diff/60001/testing/iossim/io...
testing/iossim/iossim.mm:813: #if !defined(IOSSIM_USE_XCODE_6)
will this ever get defined to zero?  i.e. do you just want !IOSSIM_USE_XCODE_6?

https://chromiumcodereview.appspot.com/494583004/diff/60001/testing/iossim/io...
testing/iossim/iossim.mm:822: NSAutoreleasePool* pool = [[NSAutoreleasePool
alloc] init];
create the pool first, the do the check.

[lliabraa, 2014-08-25 13:28:36]

https://chromiumcodereview.appspot.com/494583004/diff/60001/testing/iossim/io...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/494583004/diff/60001/testing/iossim/io...
testing/iossim/iossim.mm:182: LogError(@"Task '%@ %@' exited with return code
%@.",
On 2014/08/25 13:19:03, TVL wrote:
> isn't terminationStatus an int?  (you are using %@)

Done. changed to %d

https://chromiumcodereview.appspot.com/494583004/diff/60001/testing/iossim/io...
testing/iossim/iossim.mm:813: #if !defined(IOSSIM_USE_XCODE_6)
On 2014/08/25 13:19:03, TVL wrote:
> will this ever get defined to zero?  i.e. do you just want
!IOSSIM_USE_XCODE_6?

Done.

https://chromiumcodereview.appspot.com/494583004/diff/60001/testing/iossim/io...
testing/iossim/iossim.mm:822: NSAutoreleasePool* pool = [[NSAutoreleasePool
alloc] init];
On 2014/08/25 13:19:03, TVL wrote:
> create the pool first, the do the check.

Done.

[lliabraa, 2014-08-25 13:41:05]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-08-25 13:41:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lliabraa@chromium.org/494583004/100001

[commit-bot: I haz the power, 2014-08-25 14:44:47]

Committed patchset #6 (100001) as d7875158bb93ef51cc3bfc59e23ca35ed50c5042

[commit-bot: I haz the power, 2014-09-10 02:34:29]

Patchset 6 (id:??) landed as
https://crrev.com/7f590bcff76926fc8442e020dcd1eebf604bf129
Cr-Commit-Position: refs/heads/master@{#291681}