Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 49253005: Fetch extension blacklist states from SafeBrowsing server (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.h ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index cdc45e5dae31bc3039e30eff4470aa308c7db32b..818fa8f1921b565139100af9c8268a9767cd0f11 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -126,7 +126,7 @@ CrxInstaller::CrxInstaller(
did_handle_successfully_(true),
error_on_unsupported_requirements_(false),
has_requirement_errors_(false),
- blacklist_state_(extensions::Blacklist::NOT_BLACKLISTED),
+ blacklist_state_(extensions::NOT_BLACKLISTED),
install_wait_for_idle_(true),
update_from_settings_page_(false),
installer_(service_weak->profile()) {
@@ -519,14 +519,15 @@ void CrxInstaller::OnRequirementsChecked(
}
void CrxInstaller::OnBlacklistChecked(
- extensions::Blacklist::BlacklistState blacklist_state) {
+ extensions::BlacklistState blacklist_state) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
if (!service_weak_)
return;
blacklist_state_ = blacklist_state;
- if (blacklist_state_ == extensions::Blacklist::BLACKLISTED_MALWARE &&
+ if ((blacklist_state_ == extensions::BLACKLISTED_MALWARE ||
+ blacklist_state_ == extensions::BLACKLISTED_UNKNOWN) &&
!allow_silent_install_) {
// User tried to install a blacklisted extension. Show an error and
// refuse to install it.
« no previous file with comments | « chrome/browser/extensions/crx_installer.h ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698