Fetch extension blacklist states from SafeBrowsing server

chrome/browser/extensions/blacklist_fetcher.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_BLACKLIST_FETCHER_H_
+#define CHROME_BROWSER_EXTENSIONS_BLACKLIST_FETCHER_H_
+
+#include <set>
+#include <string>
+
+#include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/extensions/blacklist.h"
+#include "net/url_request/url_fetcher.h"
+#include "net/url_request/url_fetcher_delegate.h"
+
+namespace extensions {
+
+class BlacklistFetcher : public net::URLFetcherDelegate {

[not at google - send to devlin, 2013/11/18 17:03:49]

comment

also I made this comment earlier, but should this be BlacklistStateFetcher,
since the actual blacklist fetching happens elsewhere?

[Oleg Eterevsky, 2013/11/20 12:58:45]

Done.

+ public:
+  BlacklistFetcher();
+
+  typedef base::Callback<void(Blacklist::BlacklistState)> RequestCallback;
+
+  virtual void Request(const std::string& id, const RequestCallback& callback);
+
+  void SetSafeBrowsingConfig(const SafeBrowsingProtocolConfig& config);
+
+ protected:
+  // net::URLFetcherDelegate interface.
+  virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
+
+ private:
+  GURL RequestUrl() const;
+
+  SafeBrowsingProtocolConfig safe_browsing_config_;
+  bool safe_browsing_config_initialized_;
+
+  // ID for URLFetchers for testing.
+  int url_fetcher_id_;
+
+  // Extension id by URLFetcher.
+  std::map<const net::URLFetcher*, std::string> requests_;

[not at google - send to devlin, 2013/11/18 18:21:28]

also, I think you need to delete all of the unresolved net::URLFetchers when the
BlacklistFetcher is destroyed.

[Oleg Eterevsky, 2013/11/20 12:58:45]

Done. Nice catch.

+
+  typedef std::multimap<std::string, RequestCallback> CallbackMultiMap;
+
+  // Callbacks by

[not at google - send to devlin, 2013/11/18 17:03:49]

extension ID?

[Oleg Eterevsky, 2013/11/20 12:58:45]

Done.

+  CallbackMultiMap callbacks_;
+
+  DISALLOW_COPY_AND_ASSIGN(BlacklistFetcher);
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_BLACKLIST_FETCHER_H_
+