Issue 49223002: fix webui for sdk 0.8.7

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49223002: fix webui for sdk 0.8.7 (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
7 years, 1 month ago

Reviewers:
dgrove, Jennifer Messerly

CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/web-ui.git@master

Visibility:
Public.

More Reviews

Description

fix webui for sdk 0.8.7 R=jmesserly@google.com Committed: https://github.com/dart-lang/web-ui/commit/c2b4df2

Patch Set 1 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -47 lines)			Patch
M	lib/component_build.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/observe/observable.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	lib/observe/set.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	lib/src/compiler.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/src/html_css_fixup.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/src/messages.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/src/utils_observe.dart	View	2 chunks	+1 line, -18 lines	0 comments	Download
M	test/data/expected/code_in_dart_file_test.html.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/data/expected/conditional3_test.html.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/data/expected/conditional4_test.html.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/data/expected/observe_test.html.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/data/expected/recursive_component_test.html.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/data/input/final_one_time_binding_test.html	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	test/data/input/table_test.html	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	test/data/input/trim_indentation_space2_test.html	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	test/data/input/trim_indentation_space_test.html	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/observe_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/run_all.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/testing.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

On 2013/10/28 17:12:45, Siggi Cherem (dart-lang) wrote: lgtm

7 years, 1 month ago (2013-10-28 17:16:01 UTC) #2

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-10-28 17:17:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rc2b4df2 (presubmit successful).

Expand Messages | Collapse Messages