Chromium Code Reviews
Help | Chromium Project | Sign in
(398)

Issue 49223002: fix webui for sdk 0.8.7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 9 months ago
Reviewers:
dgrove, John Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -47 lines) Patch
M lib/component_build.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/observe/observable.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M lib/observe/set.dart View 2 chunks +5 lines, -1 line 0 comments Download
M lib/src/compiler.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/src/html_css_fixup.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/messages.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/utils_observe.dart View 2 chunks +1 line, -18 lines 0 comments Download
M test/data/expected/code_in_dart_file_test.html.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/data/expected/conditional3_test.html.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M test/data/expected/conditional4_test.html.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M test/data/expected/observe_test.html.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/data/expected/recursive_component_test.html.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M test/data/input/final_one_time_binding_test.html View 1 chunk +3 lines, -2 lines 0 comments Download
M test/data/input/table_test.html View 2 chunks +2 lines, -1 line 0 comments Download
M test/data/input/trim_indentation_space2_test.html View 2 chunks +2 lines, -1 line 0 comments Download
M test/data/input/trim_indentation_space_test.html View 1 chunk +2 lines, -1 line 0 comments Download
M test/observe_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/run_all.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/testing.dart View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
1 year, 9 months ago (2013-10-28 17:12:45 UTC) #1
John Messerly
On 2013/10/28 17:12:45, Siggi Cherem (dart-lang) wrote: lgtm
1 year, 9 months ago (2013-10-28 17:16:01 UTC) #2
Siggi Cherem (dart-lang)
1 year, 9 months ago (2013-10-28 17:17:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rc2b4df2 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5