Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 490213003: Add gyp file which builds all compiled_resources.gyp files in Chrome (Closed)

Created:
6 years, 4 months ago by Vitaly Pavlenko
Modified:
6 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master
Project:
chromium
Visibility:
Public.

Description

Add gyp file which builds all compiled_resources.gyp files in Chrome BUG=393873 R=dbeam@chromium.org TEST=gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291244

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove (c) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
A third_party/closure_compiler/compiled_resources.gyp View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Pavlenko
6 years, 4 months ago (2014-08-21 16:24:53 UTC) #1
Dan Beam
lgtm https://chromiumcodereview.appspot.com/490213003/diff/1/third_party/closure_compiler/compiled_resources.gyp File third_party/closure_compiler/compiled_resources.gyp (right): https://chromiumcodereview.appspot.com/490213003/diff/1/third_party/closure_compiler/compiled_resources.gyp#newcode1 third_party/closure_compiler/compiled_resources.gyp:1: # Copyright (c) 2014 The Chromium Authors. All ...
6 years, 4 months ago (2014-08-21 17:39:34 UTC) #2
Vitaly Pavlenko
https://chromiumcodereview.appspot.com/490213003/diff/1/third_party/closure_compiler/compiled_resources.gyp File third_party/closure_compiler/compiled_resources.gyp (right): https://chromiumcodereview.appspot.com/490213003/diff/1/third_party/closure_compiler/compiled_resources.gyp#newcode1 third_party/closure_compiler/compiled_resources.gyp:1: # Copyright (c) 2014 The Chromium Authors. All rights ...
6 years, 4 months ago (2014-08-21 17:50:55 UTC) #3
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 4 months ago (2014-08-21 17:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/490213003/20001
6 years, 4 months ago (2014-08-21 17:51:39 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:36:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 291244

Powered by Google App Engine
This is Rietveld 408576698