Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 48643003: Moved extension and value builder code to extensions component. (Closed)

Created:
7 years, 1 month ago by benwells
Modified:
7 years, 1 month ago
Reviewers:
Yoyo Zhou, sky
CC:
chromium-reviews, pam+watch_chromium.org, extensions-reviews_chromium.org, felt, nkostylev+watch_chromium.org, tzik, jam, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, nhiroki+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Moved extension and value builder code to extensions component. This is only used by tests but it has no chrome dependencies, and test in extensions use it, so it should move down to. TBR=sky@chromium.org BUG=162530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233119

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -397 lines) Patch
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_tab_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/page_action_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/script_badge_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/script_bubble_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_environment.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_fake_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/value_store/value_store_change_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/extension_builder.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/common/extensions/extension_builder.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/common/extensions/extension_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/features/base_feature_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/features/complex_feature_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/features/simple_feature_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/value_builder.h View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/common/extensions/value_builder.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/extension_builder.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/common/extension_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/value_builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/value_builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
benwells
Simple one. Not sure how important it is but it was easy.
7 years, 1 month ago (2013-10-31 06:55:28 UTC) #1
Yoyo Zhou
LGTM, yes, we use it for tests.
7 years, 1 month ago (2013-10-31 20:35:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/48643003/1
7 years, 1 month ago (2013-10-31 23:28:36 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=33839
7 years, 1 month ago (2013-11-01 00:52:42 UTC) #4
Yoyo Zhou
Same DEPS issue as the other one.
7 years, 1 month ago (2013-11-01 01:09:04 UTC) #5
benwells
On 2013/11/01 01:09:04, Yoyo Zhou wrote: > Same DEPS issue as the other one. I ...
7 years, 1 month ago (2013-11-01 02:05:29 UTC) #6
benwells
+sky for refactoring fallout
7 years, 1 month ago (2013-11-04 02:14:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/48643003/160001
7 years, 1 month ago (2013-11-04 02:14:49 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218335
7 years, 1 month ago (2013-11-04 03:50:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/48643003/160001
7 years, 1 month ago (2013-11-04 05:28:20 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-04 07:10:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/48643003/430001
7 years, 1 month ago (2013-11-04 09:20:14 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218413
7 years, 1 month ago (2013-11-04 11:33:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/48643003/430001
7 years, 1 month ago (2013-11-04 20:53:51 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218940
7 years, 1 month ago (2013-11-05 01:59:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/48643003/430001
7 years, 1 month ago (2013-11-05 04:15:58 UTC) #16
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 04:46:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/48643003/430001
7 years, 1 month ago (2013-11-05 11:50:04 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219575
7 years, 1 month ago (2013-11-05 15:57:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/48643003/430001
7 years, 1 month ago (2013-11-05 19:40:05 UTC) #20
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 22:52:47 UTC) #21
Message was sent while issue was closed. 
Change committed as 233119

Powered by Google App Engine
This is Rietveld 408576698