Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 48443002: Do not update survival rate if the new space size is zero. (Closed)

Created:
7 years, 1 month ago by ulan
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Do not update survival rate if the new space size is zero. BUG=v8:2333 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17753

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Remove assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/heap.cc View 2 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 1 month ago (2013-10-28 10:58:56 UTC) #1
Hannes Payer (out of office)
LGTM, nice catch.
7 years, 1 month ago (2013-10-28 12:26:53 UTC) #2
ulan
7 years, 1 month ago (2013-11-14 15:25:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r17753 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698