Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 483873003: Add gclient hook that checks local git configuration. (Closed)

Created:
6 years, 4 months ago by Vadim Sh.
Modified:
5 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add gclient hook that checks local git configuration. It will also verify committers can commit by attempting to push to a test git repository. It will run only once (or rather once per git configuration), so it shouldn't significantly increase runhooks duration. R=iannucci@chromium.org BUG=399054 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290653

Patch Set 1 #

Patch Set 2 : rename to check_git_config.py #

Total comments: 2

Patch Set 3 : move to bottom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M DEPS View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vadim Sh.
ptal
6 years, 4 months ago (2014-08-18 20:57:18 UTC) #1
iannucci
lgtm https://chromiumcodereview.appspot.com/483873003/diff/20001/DEPS File DEPS (right): https://chromiumcodereview.appspot.com/483873003/diff/20001/DEPS#newcode821 DEPS:821: # of SVN history forever though. can drop ...
6 years, 4 months ago (2014-08-19 00:42:29 UTC) #2
Vadim Sh.
https://chromiumcodereview.appspot.com/483873003/diff/20001/DEPS File DEPS (right): https://chromiumcodereview.appspot.com/483873003/diff/20001/DEPS#newcode821 DEPS:821: # of SVN history forever though. On 2014/08/19 00:42:29, ...
6 years, 4 months ago (2014-08-19 00:57:43 UTC) #3
Vadim Sh.
The CQ bit was checked by vadimsh@chromium.org
6 years, 4 months ago (2014-08-19 19:54:23 UTC) #4
Vadim Sh.
The CQ bit was unchecked by vadimsh@chromium.org
6 years, 4 months ago (2014-08-19 19:54:52 UTC) #5
Vadim Sh.
The CQ bit was checked by vadimsh@chromium.org
6 years, 4 months ago (2014-08-19 20:30:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/483873003/40001
6 years, 4 months ago (2014-08-19 20:31:28 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (40001) as 290653
6 years, 4 months ago (2014-08-19 20:32:30 UTC) #8
kjellander_chromium
5 years, 9 months ago (2015-03-16 12:43:45 UTC) #9
Message was sent while issue was closed.
On 2014/08/19 20:32:30, I haz the power (commit-bot) wrote:
> Committed patchset #3 (40001) as 290653

I guess it's about time to remove this one, right?

Powered by Google App Engine
This is Rietveld 408576698