Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a unit test for the reload case Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 85478938b615fe29f1a4981ba6af30da94c8ab43..8ea8fb743db5362f2f0a048e43fd5f12bf961c62 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1197,6 +1197,20 @@ void RenderFrameHostImpl::NotificationClosed(int notification_id) {
cancel_notification_callbacks_.erase(notification_id);
}
+// PlzNavigate
+void RenderFrameHostImpl::CommitNavigation(
+ const FrameMsg_CommitNavigation_Params& params) {
+ // TODO(clamy): Check if we have to add security checks for the browser plugin
+ // guests.
+
+ // Get back to a clean state, in case we start a new navigation without
+ // completing a RVH swap or unload handler.
+ render_view_host_->SetState(RenderViewHostImpl::STATE_DEFAULT);
(Do not use) nasko 2014/08/28 16:39:08 Setting this unconditionally can be problematic. W
clamy 2014/09/02 18:25:19 Done.
+ Send(new FrameMsg_CommitNavigation(routing_id_, params));
+ // TODO(clamy): Check if we have to be concerned about throbbing javascript
+ // urls.
+}
+
void RenderFrameHostImpl::PlatformNotificationPermissionRequestDone(
int request_id, blink::WebNotificationPermission permission) {
Send(new PlatformNotificationMsg_PermissionRequestComplete(

Powered by Google App Engine
This is Rietveld 408576698