content/browser/frame_host/render_frame_host_impl.h - Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split the class into structs used by IPCs Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_request_info.h ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 4c38d7a6dbcbb7b3bea744d12940596d7222bfb5..50c5adc8aa8fa30e49c9efe81254da553e680da1 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -31,6 +31,7 @@ struct AccessibilityHostMsg_LocationChangeParams;

struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;

struct FrameHostMsg_OpenURL_Params;

struct FrameHostMsg_BeginNavigation_Params;

+struct FrameMsg_CommitNavigation_Params;

struct FrameMsg_Navigate_Params;

#if defined(OS_MACOSX) || defined(OS_ANDROID)

struct FrameHostMsg_ShowPopup_Params;

@@ -286,6 +287,9 @@ class CONTENT_EXPORT RenderFrameHostImpl

void DidCancelPopupMenu();

#endif

+ // PlzNavigate: Indicates that a navigation has committed and is ready for

Charlie Reis 2014/09/15 21:19:39 "has committed" sounds wrong to me. This is calle

clamy 2014/09/18 20:50:39 Is it better now?

+ // processing by this RenderFrameHost.

+ void CommitNavigation(const FrameMsg_CommitNavigation_Params& params);

protected:

friend class RenderFrameHostFactory;