Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a class to keep track of navigation parameters Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index b461ae05cc6e2630c26f9e11cc7f51f854d2961a..729ad086322c204274ad6dc522069656d3b9498d 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -15,6 +15,7 @@ struct FrameMsg_Navigate_Params;
namespace content {
class NavigationControllerImpl;
+class NavigationParameters;
class NavigatorDelegate;
struct LoadCommittedDetails;
@@ -25,13 +26,6 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
NavigatorImpl(NavigationControllerImpl* navigation_controller,
NavigatorDelegate* delegate);
- // Fills in |params| based on the content of |entry|.
- static void MakeNavigateParams(const NavigationEntryImpl& entry,
- const NavigationControllerImpl& controller,
- NavigationController::ReloadType reload_type,
- base::TimeTicks navigation_start,
- FrameMsg_Navigate_Params* params);
-
// Navigator implementation.
virtual NavigationController* GetController() OVERRIDE;
virtual void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
@@ -77,8 +71,13 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
bool user_gesture) OVERRIDE;
virtual void CommitNavigation(
RenderFrameHostImpl* render_frame_host,
- const NavigationBeforeCommitInfo& info) OVERRIDE;
+ const FrameMsg_CommitNavigation_Params& commit_navigation_params)
+ OVERRIDE;
+ // PlzNavigate
+ NavigationParameters* MakeNavigationParametersForTest(
+ const NavigationEntryImpl& entry,
+ NavigationController::ReloadType reload_type);
private:
virtual ~NavigatorImpl() {}

Powered by Google App Engine
This is Rietveld 408576698