PlzNavigate: implement CommitNavigation on the browser side

content/browser/frame_host/navigation_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
-#include "content/browser/frame_host/navigation_request_info.h"
+#include "base/memory/scoped_ptr.h"
 #include "content/common/content_export.h"
+#include "content/common/navigation_params.h"
 
 namespace content {
 class ResourceRequestBody;
+struct NavigationRequestInfo;
 
 // PlzNavigate
 // A UI thread object that owns a navigation request until it commits. It
 // ensures the UI thread can start a navigation request in the
 // ResourceDispatcherHost (that lives on the IO thread).
 // TODO(clamy): Describe the interactions between the UI and IO thread during
 // the navigation following its refactoring.
 class NavigationRequest {
  public:
-  NavigationRequest(const NavigationRequestInfo& info,
-                    int64 frame_tree_node_id);
+  NavigationRequest(int64 frame_tree_node_id,
+                    const CoreNavigationParams& core_params,
+                    const CommitNavigationParams& commit_params);
 
   ~NavigationRequest();
 
   // Called on the UI thread by the RenderFrameHostManager which owns the
-  // NavigationRequest. After calling this function, |body| can no longer be
-  // manipulated on the UI thread.
-  void BeginNavigation(scoped_refptr<ResourceRequestBody> body);
+  // NavigationRequest. Takes ownership of |info|. After calling this function,
+  // |body| can no longer be manipulated on the UI thread.
+  void BeginNavigation(scoped_ptr<NavigationRequestInfo> info,
+                       scoped_refptr<ResourceRequestBody> body);
 
   // Called on the UI thread by the RenderFrameHostManager which owns the
   // NavigationRequest whenever this navigation request should be canceled.
   void CancelNavigation();
 
-  const NavigationRequestInfo& info() const { return info_; }
+  int64 frame_tree_node_id() const { return frame_tree_node_id_; }
+  int64 navigation_request_id() const { return navigation_request_id_; }
 
-  int64 frame_tree_node_id() const { return frame_tree_node_id_; }
+  CoreNavigationParams& core_params() { return core_params_; }
 
-  int64 navigation_request_id() const { return navigation_request_id_; }
+  const CommitNavigationParams& commit_params() const { return commit_params_; }
+
+  NavigationRequestInfo* info() const { return info_.get(); }
 
  private:
   const int64 navigation_request_id_;
-  const NavigationRequestInfo info_;
   const int64 frame_tree_node_id_;
 
+  // Initialized on creation of the NavigationRequest. Sent to the renderer when
+  // the navigation is ready to commit.
+  CoreNavigationParams core_params_;
+  const CommitNavigationParams commit_params_;

[nasko, 2014/09/26 22:16:43]

nit: This seems to work, but looks strange. In my mind, commit parameters aren't
all known until commit time, yet they are declared const at the beginning of the
navigation.

[clamy, 2014/09/29 20:45:30]

As of now, all parameters in CommitParams are known at the start of navigation.
If it changes, I will make commit_params_ non const. Is that okay with you?

[nasko, 2014/09/29 22:12:11]

sgtm

+
+  // Initialized when beginning the navigation.
+  scoped_ptr<NavigationRequestInfo> info_;
+
   DISALLOW_COPY_AND_ASSIGN(NavigationRequest);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_H_