Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split the class into structs used by IPCs Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
11 #include "ui/base/window_open_disposition.h" 11 #include "ui/base/window_open_disposition.h"
12 12
13 class GURL; 13 class GURL;
14 struct FrameHostMsg_BeginNavigation_Params; 14 struct FrameHostMsg_BeginNavigation_Params;
15 struct FrameMsg_CommitNavigation_Params;
15 struct FrameHostMsg_DidCommitProvisionalLoad_Params; 16 struct FrameHostMsg_DidCommitProvisionalLoad_Params;
16 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params; 17 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
17 18
18 namespace base { 19 namespace base {
19 class TimeTicks; 20 class TimeTicks;
20 } 21 }
21 22
22 namespace content { 23 namespace content {
23 24
24 class NavigationControllerImpl; 25 class NavigationControllerImpl;
25 class NavigationEntryImpl; 26 class NavigationEntryImpl;
26 class NavigatorDelegate; 27 class NavigatorDelegate;
27 class RenderFrameHostImpl; 28 class RenderFrameHostImpl;
28 struct NavigationBeforeCommitInfo;
29 29
30 // Implementations of this interface are responsible for performing navigations 30 // Implementations of this interface are responsible for performing navigations
31 // in a node of the FrameTree. Its lifetime is bound to all FrameTreeNode 31 // in a node of the FrameTree. Its lifetime is bound to all FrameTreeNode
32 // objects that are using it and will be released once all nodes that use it are 32 // objects that are using it and will be released once all nodes that use it are
33 // freed. The Navigator is bound to a single frame tree and cannot be used by 33 // freed. The Navigator is bound to a single frame tree and cannot be used by
34 // multiple instances of FrameTree. 34 // multiple instances of FrameTree.
35 // TODO(nasko): Move all navigation methods, such as didStartProvisionalLoad 35 // TODO(nasko): Move all navigation methods, such as didStartProvisionalLoad
36 // from WebContentsImpl to this interface. 36 // from WebContentsImpl to this interface.
37 class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> { 37 class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
38 public: 38 public:
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 const Referrer& referrer, 116 const Referrer& referrer,
117 PageTransition page_transition, 117 PageTransition page_transition,
118 WindowOpenDisposition disposition, 118 WindowOpenDisposition disposition,
119 const GlobalRequestID& transferred_global_request_id, 119 const GlobalRequestID& transferred_global_request_id,
120 bool should_replace_current_entry, 120 bool should_replace_current_entry,
121 bool user_gesture) {} 121 bool user_gesture) {}
122 122
123 // PlzNavigate 123 // PlzNavigate
124 // Signal |render_frame_host| that a navigation is ready to commit (the 124 // Signal |render_frame_host| that a navigation is ready to commit (the
125 // response to the navigation request has been received). 125 // response to the navigation request has been received).
126 virtual void CommitNavigation(RenderFrameHostImpl* render_frame_host, 126 virtual void CommitNavigation(
127 const NavigationBeforeCommitInfo& info) {}; 127 RenderFrameHostImpl* render_frame_host,
128 const FrameMsg_CommitNavigation_Params& commit_navigation_params) {}
128 129
129 protected: 130 protected:
130 friend class base::RefCounted<Navigator>; 131 friend class base::RefCounted<Navigator>;
131 virtual ~Navigator() {} 132 virtual ~Navigator() {}
132 }; 133 };
133 134
134 } // namespace content 135 } // namespace content
135 136
136 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 137 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698