PlzNavigate: implement CommitNavigation on the browser side

content/browser/frame_host/navigation_request_info.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_INFO_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_INFO_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 14 matching lines @@
 
   // ---------------------------------------------------------------------------
   // The following parameters should be filled in by RenderFrameHostManager
   // before the navigation request is sent to the ResourceDispatcherHost.
 
   // Usually the URL of the document in the top-level window, which may be
   // checked by the third-party cookie blocking policy.
   GURL first_party_for_cookies;
   bool is_main_frame;
   bool parent_is_main_frame;
+
+  // Whether or not we should allow the URL to download.

[Charlie Reis, 2014/09/15 21:19:39]

This comment is a bit unclear.  What value does this have when it's not a
download (the common case), and how can you tell whether it's a download or not?

[clamy, 2014/09/18 20:50:39]

This is required by the loader, and I think it is true by default. I am not sure
if it can actually be false for a navigation request.

+  bool allow_download;

[Charlie Reis, 2014/09/15 21:19:39]

This is also one of the "request info" struct items.  Why isn't that struct
being used here?

 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_REQUEST_INFO_H_