PlzNavigate: implement CommitNavigation on the browser side

content/common/frame_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for interacting with frames.
 // Multiply-included message file, hence no include guard.
 
 #include "content/common/content_export.h"
 #include "content/common/content_param_traits.h"
 #include "content/common/frame_message_enums.h"
@@ skipping 278 matching lines @@
   IPC_STRUCT_MEMBER(int, load_flags)
 
   // Optional resource request body (may be null).
   IPC_STRUCT_MEMBER(scoped_refptr<content::ResourceRequestBody>,
                     request_body)
 
   // True if the request was user initiated.
   IPC_STRUCT_MEMBER(bool, has_user_gesture)
 
   IPC_STRUCT_MEMBER(content::PageTransition, transition_type)
+IPC_STRUCT_END()
 
-  // Whether this navigation should replace the current session history entry on
-  // commit.
-  IPC_STRUCT_MEMBER(bool, should_replace_current_entry)
+IPC_STRUCT_BEGIN(FrameMsg_CommitNavigation_Params)
+  // The URL to commit.
+  IPC_STRUCT_MEMBER(GURL, url)

[(Do not use) nasko, 2014/09/05 17:04:49]

Yeah, this is the point I was trying to make. This message has a huge overlap
with FrameMsg_Navigate_Params. We can always pass two structs in an IPC:

Send(new FrameMsg_Navigate(FrameMsg_NavigationParams, FrameMsg_Commit_Params))

This way we can "compose" all parameters based on the common and specific ones.

[clamy, 2014/09/05 18:21:25]

So should this be split up in something like FrameMsg_CoreNavigation_Params,
FrameMsg_CommitNavigation_Params and FrameMsg_Navigate_Params? Or maybe define a
content::NavigationCoreParams and have both FrameMsg_CommitNavigation_Params and
FrameMsg_Navigate_Params be IPC struct with parent as is done for
FrameHostMsg_DidCommitProvisionalLoad_Params?

 
-  // Whether or not we should allow the URL to download.
-  IPC_STRUCT_MEMBER(bool, allow_download)
+  // The URL to request to the browser to get access to the stream of data.
+  IPC_STRUCT_MEMBER(GURL, stream_url)
+
+  // The page_id for this navigation, or -1 if it is a new navigation.  Back,
+  // Forward, and Reload navigations should have a valid page_id.  If the load
+  // succeeds, then this page_id will be reflected in the resultant
+  // FrameHostMsg_DidCommitProvisionalLoad message.
+  IPC_STRUCT_MEMBER(int32, page_id)
+
+  // If page_id is -1, then pending_history_list_offset will also be -1.
+  // Otherwise, it contains the offset into the history list corresponding to
+  // the current navigation.
+  IPC_STRUCT_MEMBER(int, pending_history_list_offset)
+
+  // Informs the RenderView of where its current page contents reside in
+  // session history and the total size of the session history list.
+  IPC_STRUCT_MEMBER(int, current_history_list_offset)
+  IPC_STRUCT_MEMBER(int, current_history_list_length)
+
+  // Informs the RenderView the session history should be cleared. In that
+  // case, the RenderView needs to notify the browser that the clearing was
+  // succesful when the navigation commits.
+  IPC_STRUCT_MEMBER(bool, should_clear_history_list)
+
+  // TODO(clamy): Investigate whether we should support data urls here.
+
+  // The URL to send in the "Referer" header field. Can be empty if there is
+  // no referrer.
+  IPC_STRUCT_MEMBER(content::Referrer, referrer)
+
+  // TODO(clamy): Investigate whether we should send the chain of redirects
+  // along.
+
+  // The type of transition.
+  IPC_STRUCT_MEMBER(content::PageTransition, transition)
+
+  // Opaque history state (received by ViewHostMsg_UpdateState).
+  IPC_STRUCT_MEMBER(content::PageState, page_state)
+
+  // Type of navigation.
+  IPC_STRUCT_MEMBER(FrameMsg_Navigate_Type::Value, navigation_type)
+
+  // Whether or not the user agent override string should be used.
+  IPC_STRUCT_MEMBER(bool, is_overriding_user_agent)
+
+  // The navigationStart time to expose through the Navigation Timing API to JS.
+  IPC_STRUCT_MEMBER(base::TimeTicks, browser_navigation_start)
+
+  // TODO(clamy): Add other timing values needed by the Navigation Timing API
+  // (redirects, etc...).
 IPC_STRUCT_END()
 
 #if defined(OS_MACOSX) || defined(OS_ANDROID)
 // This message is used for supporting popup menus on Mac OS X and Android using
 // native controls. See the FrameHostMsg_ShowPopup message.
 IPC_STRUCT_BEGIN(FrameHostMsg_ShowPopup_Params)
   // Position on the screen.
   IPC_STRUCT_MEMBER(gfx::Rect, bounds)
 
   // The height of each item in the menu.
@@ skipping 158 matching lines @@
                     std::vector<int> /* selected indices */)
 
 #elif defined(OS_MACOSX)
 
 // External popup menus.
 IPC_MESSAGE_ROUTED1(FrameMsg_SelectPopupMenuItem,
                     int /* selected index, -1 means no selection */)
 
 #endif
 
+// Tells the renderer to commit the specific navigation, as part of the
+// browser-side navigation refactoring.
+IPC_MESSAGE_ROUTED1(FrameMsg_CommitNavigation, FrameMsg_CommitNavigation_Params)
+
 // -----------------------------------------------------------------------------
 // Messages sent from the renderer to the browser.
 
 // Blink and JavaScript error messages to log to the console
 // or debugger UI.
 IPC_MESSAGE_ROUTED4(FrameHostMsg_AddMessageToConsole,
                     int32, /* log level */
                     base::string16, /* msg */
                     int32, /* line number */
                     base::string16 /* source id */ )
@@ skipping 268 matching lines @@
 IPC_MESSAGE_ROUTED0(FrameHostMsg_DidFirstVisuallyNonEmptyPaint)
 
 #if defined(OS_MACOSX) || defined(OS_ANDROID)
 
 // Message to show/hide a popup menu using native controls.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_ShowPopup,
                     FrameHostMsg_ShowPopup_Params)
 IPC_MESSAGE_ROUTED0(FrameHostMsg_HidePopup)
 
 #endif