Issue 483263004: A type for unsupported browser objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 483263004: A type for unsupported browser objects (Closed)

Created:
6 years, 3 months ago by vsm

Modified:
6 years, 3 months ago

Reviewers:
Leaf, siva

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

A type for unsupported browser objects This should fix the crash in bug 20592. We currently crash if we do not find the right type in the type table. Siva found it on AnimationTimeline, but there may be others now and going forward. (Note, objects of this type could actually be used in dart:_blink since they have the right c++ pointer and type id.) This is the Blink side: https://chromiumcodereview.appspot.com/490033005/ BUG=dartbug.com/20592 R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=39577

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -4 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	tools/dom/src/html_native_DOMImplementation.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

vsm@google.com changed reviewers: + asiva@google.com, leafp@google.com

6 years, 3 months ago (2014-08-26 14:51:36 UTC) #1

vsm

6 years, 3 months ago (2014-08-27 07:47:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 39577 (presubmit successful).

Expand Messages | Collapse Messages