Issue 477313002: DevTools: Extract WorkerInspectorProxy interface from WorkerGlobalScopeProxy.

Issue 477313002: DevTools: Extract WorkerInspectorProxy interface from WorkerGlobalScopeProxy. (Closed)

Created:
6 years, 4 months ago by vsevik

Modified:
6 years, 4 months ago

Reviewers:
sergeyv, yurys, pfeldman

CC:
blink-reviews, falken, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, horo+watch_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, kinuko+worker_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Extract WorkerInspectorProxy interface from WorkerGlobalScopeProxy. WorkerGlobalScopeProxy is dedicated worker specific, while this interface could be reused for shared/service workers as well. BUG=404355 R=pfeldman, yurys, sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180441

Patch Set 1 #

Patch Set 2 : Fixed compile #

Total comments: 3

Patch Set 3 : Comments addressed. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -50 lines)			Patch
M	Source/core/core.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.idl	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorWorkerAgent.h	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/inspector/InspectorWorkerAgent.cpp	View		11 chunks	+24 lines, -23 lines	0 comments	Download
M	Source/core/workers/WorkerGlobalScopeProxy.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
A	Source/core/workers/WorkerInspectorProxy.h	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download
M	Source/core/workers/WorkerMessagingProxy.h	View	1 2	4 chunks	+7 lines, -3 lines	0 comments	Download
M	Source/core/workers/WorkerMessagingProxy.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

LGTM once comments are addressed. https://chromiumcodereview.appspot.com/477313002/diff/20001/Source/core/workers/WorkerInspectorProxy.h File Source/core/workers/WorkerInspectorProxy.h (right): https://chromiumcodereview.appspot.com/477313002/diff/20001/Source/core/workers/WorkerInspectorProxy.h#newcode12 Source/core/workers/WorkerInspectorProxy.h:12: // A proxy for ...

6 years, 4 months ago (2014-08-18 06:20:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/477313002/40001

6 years, 4 months ago (2014-08-18 09:18:32 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-18 10:25:56 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-18 10:33:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (40001) as 180441

Expand Messages | Collapse Messages