Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 475783002: PlzNavigate: add cancel navigation logic for uncommitted requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed failed test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index d552ee99af64e3133a884c6f93bb9af976d2cf43..6fcb94122deb087aa949dec2e8299f08e17b58d1 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -106,6 +106,16 @@ RenderFrameHostManager::~RenderFrameHostManager() {
// Delete any swapped out RenderFrameHosts.
STLDeleteValues(&proxy_hosts_);
+
+ // PlzNavigate
+ // There is an active navigation request for this RFHM so it needs to be
+ // canceled.
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableBrowserSideNavigation)) {
+ if (navigation_request_.get())
+ navigation_request_->CancelNavigation();
+ }
+
}
void RenderFrameHostManager::Init(BrowserContext* browser_context,
@@ -428,6 +438,14 @@ void RenderFrameHostManager::ResumeResponseDeferredAtStart() {
void RenderFrameHostManager::DidNavigateFrame(
RenderFrameHostImpl* render_frame_host) {
+ // PlzNavigate
+ // The navigation request has been committed so the browser process doesn't
+ // need to care about it anymore.
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableBrowserSideNavigation)) {
+ navigation_request_.reset();
+ }
+
if (!cross_navigation_pending_) {
DCHECK(!pending_render_frame_host_);
@@ -582,6 +600,11 @@ void RenderFrameHostManager::OnBeginNavigation(
// crashed) not to display a sad tab while navigating.
// TODO(clamy): Spawn a speculative renderer process if we do not have one to
// use for the navigation.
+
+ // If there is an ongoing request it must be canceled.
+ if (navigation_request_.get())
+ navigation_request_->CancelNavigation();
+
navigation_request_.reset(new NavigationRequest(
info, frame_tree_node_->frame_tree_node_id()));
navigation_request_->BeginNavigation(params.request_body);
@@ -592,6 +615,14 @@ void RenderFrameHostManager::CommitNavigation(
const NavigationBeforeCommitInfo& info) {
CHECK(CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation));
+ DCHECK(navigation_request_.get());
+ // Ignores navigation commits if the request ID doesn't match the current
+ // active request.
+ if (navigation_request_->navigation_request_id() !=
+ info.navigation_request_id) {
+ return;
+ }
+
// Pick the right RenderFrameHost to commit the navigation.
SiteInstance* current_instance = render_frame_host_->GetSiteInstance();
// TODO(clamy): Replace the default values by the right ones. This may require
« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698