content/browser/loader/resource_dispatcher_host_impl.cc - Issue 475783002: PlzNavigate: add cancel navigation logic for uncommitted requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 475783002: PlzNavigate: add cancel navigation logic for uncommitted requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments and removed the weird Observer. Trying to get this CL through and have the mo… Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_manager_unittest.cc ('K') | « content/browser/loader/resource_dispatcher_host_impl.h ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index b11036be892df572a84e08eb8eeff8a4c07f677a..72d8d386873a1d3aad78272286677d4b0d826769 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -1623,9 +1623,16 @@ void ResourceDispatcherHostImpl::FinishedWithResourcesForRequest(

IncrementOutstandingRequestsCount(-1, *info);

}

-void ResourceDispatcherHostImpl::NavigationRequest(

+void ResourceDispatcherHostImpl::StartNavigationRequest(

const NavigationRequestInfo& info,

scoped_refptr<ResourceRequestBody> request_body,

+ int64 navigation_request_id,

+ int64 frame_node_id) {

+ NOTIMPLEMENTED();

+void ResourceDispatcherHostImpl::CancelNavigationRequest(

+ int64 navigation_request_id,

int64 frame_node_id) {

NOTIMPLEMENTED();

}