content/browser/frame_host/navigation_before_commit_info.cc - Issue 475783002: PlzNavigate: add cancel navigation logic for uncommitted requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_before_commit_info.cc

Issue 475783002: PlzNavigate: add cancel navigation logic for uncommitted requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments and removed the weird Observer. Trying to get this CL through and have the mo… Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_before_commit_info.h ('k') | content/browser/frame_host/navigation_request.h » ('j') | content/browser/frame_host/navigation_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_before_commit_info.cc

diff --git a/content/child/sync_load_response.cc b/content/browser/frame_host/navigation_before_commit_info.cc

similarity index 56%

copy from content/child/sync_load_response.cc

copy to content/browser/frame_host/navigation_before_commit_info.cc

index 163153aa23766cc3a0b71a8fa8e1730efdb7a464..f7ebb3c013e6831eea34af219d61c575de3f20c0 100644

--- a/content/child/sync_load_response.cc

+++ b/content/browser/frame_host/navigation_before_commit_info.cc

@@ -2,12 +2,11 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "content/child/sync_load_response.h"

+#include "content/browser/frame_host/navigation_before_commit_info.h"

namespace content {

-SyncLoadResponse::SyncLoadResponse() {}

-SyncLoadResponse::~SyncLoadResponse() {}

+NavigationBeforeCommitInfo::NavigationBeforeCommitInfo()

+ : navigation_request_id(0) {}

nasko 2014/09/02 14:10:57 nit: Why not initialize this to -1 or some other i

carlosk 2014/09/02 15:30:09 Done.

} // namespace content