Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: content/browser/frame_host/navigation_before_commit_info.h

Issue 475783002: PlzNavigate: add cancel navigation logic for uncommitted requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the linking issue. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_before_commit_info.h
diff --git a/content/browser/frame_host/navigation_before_commit_info.h b/content/browser/frame_host/navigation_before_commit_info.h
index 506723df92ab779520cdad9719e7b95459de83ac..68a047a6c1346c4c7024b5be7a66f43ecb88fe48 100644
--- a/content/browser/frame_host/navigation_before_commit_info.h
+++ b/content/browser/frame_host/navigation_before_commit_info.h
@@ -8,6 +8,8 @@
#include <string>
#include "base/basictypes.h"
+#include "base/time/time.h"
nasko 2014/08/21 21:53:43 nit: Is this include really needed?
carlosk 2014/08/22 13:43:02 It is for the: base::TimeTicks browser_navigation
nasko 2014/08/22 14:00:34 Acknowledged.
+#include "content/common/content_export.h"
#include "content/public/common/page_transition_types.h"
#include "content/public/common/referrer.h"
#include "url/gurl.h"
@@ -20,7 +22,7 @@ namespace content {
// thread where it should be used to send a FrameMsg_CommitNavigation message to
// the renderer.
struct NavigationBeforeCommitInfo {
- NavigationBeforeCommitInfo() {};
+ CONTENT_EXPORT NavigationBeforeCommitInfo();
// The url that is actually being loaded.
GURL navigation_url;
@@ -35,6 +37,9 @@ struct NavigationBeforeCommitInfo {
// The navigationStart time to expose to JS for this navigation.
// TODO(clamy): Add the other values that matter to the Navigation Timing API.
base::TimeTicks browser_navigation_start;
+
+ // The unique ID of this navigation request.
+ int64 navigation_request_id;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698