Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2722)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 475633006: Typecheck JS files for chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@D_asserts_codingconvention
Patch Set: looked twice Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index b938f65bfd7c2620f1de9a0964c26101684b7c92..85b1ef40831d3bc31680a6e7bc95efc9b079f29d 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -210,6 +210,10 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
const Extension* extension,
const std::vector<ExtensionPage>& pages,
const ExtensionWarningService* warning_service) {
+ // The items which are to be written into app_dict are also described in
+ // b/chrome/browser/resources/extensions/extension_list.js in @typedef
Dan Beam 2014/08/21 18:27:48 remove b/
Vitaly Pavlenko 2014/08/22 01:43:41 Done.
Dan Beam 2014/08/22 21:57:13 not done
+ // for BackendExtensionDataObject. Please update it whenever you add or remove
+ // any keys here.
base::DictionaryValue* extension_data = new base::DictionaryValue();
bool enabled = extension_service_->IsExtensionEnabled(extension->id());
GetExtensionBasicInfo(extension, enabled, extension_data);
@@ -813,6 +817,10 @@ void ExtensionSettingsHandler::ReloadUnpackedExtensions() {
void ExtensionSettingsHandler::HandleRequestExtensionsData(
const base::ListValue* args) {
+ // The items which are to be written into results are also described in
+ // b/chrome/browser/resources/extensions/extensions.js in @typedef
+ // for BackendExtensionsDataObject. Please update it whenever you add or
+ // remove any keys here.
base::DictionaryValue results;
Profile* profile = Profile::FromWebUI(web_ui());

Powered by Google App Engine
This is Rietveld 408576698