Closure compiler: add pydoc for parts of third_party/closure_compiler/.

Closure compiler: add pydoc for parts of third_party/closure_compiler/.

Also stop shadowing modules names like `file` as local variables and otherwise
adhere to the Python style guide:
https://google-styleguide.googlecode.com/svn/trunk/pyguide.html

R=tbreisacher@chromium.org
BUG=393873
TEST=pydoc checker.py processor.py

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289361

[Tyler Breisacher (Chromium), 2014-08-13 19:59:42]

lgtm

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
File third_party/closure_compiler/checker.py (right):

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:6: """A script to run Closure compiler
on JavaScript file and check for errors."""
nit: "Runs Closure Compiler on ..."

"A script to" is redundant :)

Likewise with "A class to" below.

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:14: import processor
These are generally supposed to be alphabetical right? Why not in this case?

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:54: "-server",
Side note: I believe -client is generally recommended for the Closure compiler.

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:58: _found_java = False
If I remember how Python works (which is a big if), this is a class property
(Checker._found_java) rather than a property of Checker instances (c =
Checker(); c._found_java) and you need to move it into __init__ to make it an
instance property.

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:133: error: An Closure compiler error (2
line string with error and source).
s/An/A/

[Dan Beam, 2014-08-13 20:23:45]

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
File third_party/closure_compiler/checker.py (right):

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:6: """A script to run Closure compiler
on JavaScript file and check for errors."""
On 2014/08/13 19:59:42, Tyler Breisacher (Chromium) wrote:
> nit: "Runs Closure Compiler on ..."
> 
> "A script to" is redundant :)
> 
> Likewise with "A class to" below.

Done.

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:14: import processor
On 2014/08/13 19:59:42, Tyler Breisacher (Chromium) wrote:
> These are generally supposed to be alphabetical right? Why not in this case?

processor is not a system import

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:54: "-server",
On 2014/08/13 19:59:42, Tyler Breisacher (Chromium) wrote:
> Side note: I believe -client is generally recommended for the Closure
compiler.

Acknowledged.

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:58: _found_java = False
On 2014/08/13 19:59:42, Tyler Breisacher (Chromium) wrote:
> If I remember how Python works (which is a big if), this is a class property
> (Checker._found_java) rather than a property of Checker instances (c =
> Checker(); c._found_java) and you need to move it into __init__ to make it an
> instance property.

i don't want it to be an instance property

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:133: error: An Closure compiler error (2
line string with error and source).
On 2014/08/13 19:59:41, Tyler Breisacher (Chromium) wrote:
> s/An/A/

Done.

[Tyler Breisacher (Chromium), 2014-08-13 20:27:01]

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
File third_party/closure_compiler/checker.py (right):

https://chromiumcodereview.appspot.com/475493002/diff/20001/third_party/closu...
third_party/closure_compiler/checker.py:58: _found_java = False
On 2014/08/13 20:23:45, Dan Beam wrote:
> On 2014/08/13 19:59:42, Tyler Breisacher (Chromium) wrote:
> > If I remember how Python works (which is a big if), this is a class property
> > (Checker._found_java) rather than a property of Checker instances (c =
> > Checker(); c._found_java) and you need to move it into __init__ to make it
an
> > instance property.
> 
> i don't want it to be an instance property

It looks like it's being used that way at line 102, unless I'm misreading it.

[Dan Beam, 2014-08-13 20:28:21]

Committed patchset #1 manually as 289361 (presubmit successful).