Ensure that hash for a symbol is not set to 0 when it is made external.

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
@@ skipping 8310 matching lines @@
     EXPECT(Dart_IsExternalString(utf16_str));
     EXPECT_VALID(Dart_StringLength(str, &length));
     EXPECT_EQ(expected_length, length);
     EXPECT_VALID(Dart_StringLength(utf16_str, &length));
     EXPECT_EQ(expected_length, length);
     EXPECT(Dart_IdentityEquals(str, utf16_str));
     for (intptr_t i = 0; i < length; i++) {
       EXPECT_EQ(0x4e8c, ext_utf16_str[i]);
     }
 
+    // Test with a symbol (hash value should be preserved on externalization).
+    const char* symbol_ascii = "string";
+    expected_length = strlen(symbol_ascii);
+    Dart_Handle symbol_str =
+        Api::NewHandle(isolate, Symbols::New(symbol_ascii, expected_length));
+    EXPECT_VALID(symbol_str);
+    EXPECT(Dart_IsString(symbol_str));
+    EXPECT(Dart_IsStringLatin1(symbol_str));
+    EXPECT(!Dart_IsExternalString(symbol_str));
+    EXPECT_VALID(Dart_StringLength(symbol_str, &length));
+    EXPECT_EQ(expected_length, length);
+    EXPECT(Api::UnwrapStringHandle(isolate, symbol_str).HasHash());
+
+    uint8_t ext_symbol_ascii[kLength];
+    EXPECT_VALID(Dart_StringStorageSize(symbol_str, &size));
+    str = Dart_MakeExternalString(symbol_str,
+                                  ext_symbol_ascii,
+                                  size,
+                                  &peer8,
+                                  MakeExternalCback);
+    EXPECT(Api::UnwrapStringHandle(isolate, str).HasHash());
+    EXPECT(Api::UnwrapStringHandle(isolate, str).Hash() ==
+           Api::UnwrapStringHandle(isolate, symbol_str).Hash());
+    EXPECT(Dart_IsString(str));
+    EXPECT(Dart_IsString(symbol_str));
+    EXPECT(Dart_IsStringLatin1(str));
+    EXPECT(Dart_IsStringLatin1(symbol_str));
+    EXPECT(Dart_IsExternalString(str));
+    EXPECT(Dart_IsExternalString(symbol_str));
+    EXPECT_VALID(Dart_StringLength(str, &length));
+    EXPECT_EQ(expected_length, length);
+    EXPECT_VALID(Dart_StringLength(symbol_str, &length));
+    EXPECT_EQ(expected_length, length);
+    EXPECT(Dart_IdentityEquals(str, symbol_str));
+    for (intptr_t i = 0; i < length; i++) {
+      EXPECT_EQ(symbol_ascii[i], ext_symbol_ascii[i]);
+    }
+
     Dart_ExitScope();
   }
   EXPECT_EQ(40, peer8);
   EXPECT_EQ(41, peer16);
   EXPECT_EQ(42, canonical_str_peer);
   Isolate::Current()->heap()->CollectAllGarbage();
   EXPECT_EQ(80, peer8);
   EXPECT_EQ(82, peer16);
   EXPECT_EQ(42, canonical_str_peer);  // "*" Symbol is not removed on GC.
 }
@@ skipping 265 matching lines @@
                                    NewString("main"),
                                    1,
                                    dart_args);
   int64_t value = 0;
   result = Dart_IntegerToInt64(result, &value);
   EXPECT_VALID(result);
   EXPECT_EQ(6, value);
 }
 
 }  // namespace dart