Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: Source/core/frame/ConsoleBase.h

Issue 472023002: [DevTools] ConsoleAPI messages pass through frame console (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed worker console test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/ConsoleBase.h
diff --git a/Source/core/frame/ConsoleBase.h b/Source/core/frame/ConsoleBase.h
index 1e88095f58642967a93c0a79d92d5a151ae17f66..0c197e94b8bdc48f500f0791f58bfc6541f4439d 100644
--- a/Source/core/frame/ConsoleBase.h
+++ b/Source/core/frame/ConsoleBase.h
@@ -43,6 +43,7 @@
namespace blink {
+class ConsoleMessage;
class ScriptArguments;
class ConsoleBase : public RefCountedWillBeGarbageCollectedFinalized<ConsoleBase>, public ScriptWrappable {
@@ -69,7 +70,7 @@ public:
void timelineEnd(ScriptState*, const String&);
void group(ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>);
void groupCollapsed(ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>);
- void groupEnd();
+ void groupEnd(ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>);
virtual void trace(Visitor*) { }
@@ -77,7 +78,7 @@ public:
protected:
virtual ExecutionContext* context() = 0;
- virtual void reportMessageToClient(MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack>) = 0;
+ virtual void reportMessageToConsole(PassRefPtr<ConsoleMessage>) = 0;
private:
void internalAddMessage(MessageType, MessageLevel, ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>, bool acceptNoArguments = false, bool printTrace = false);

Powered by Google App Engine
This is Rietveld 408576698