Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 472023002: [DevTools] ConsoleAPI messages pass through frame console (Closed)

Created:
6 years, 4 months ago by kozyatinskiy1
Modified:
6 years, 4 months ago
Reviewers:
vsevik, sof
CC:
blink-reviews, falken, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, horo+watch_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, kinuko+worker_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[DevTools] ConsoleAPI messages pass through frame console Before this patch all console API messages passed through InspectorConsoleAgent directly. After this messages passes through FrameConsole for Page and through WorkerGlobalScope for Worker as same as all other console messages. R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180544

Patch Set 1 : #

Patch Set 2 : Removed InspectorConsoleAgent::addConsoleAPIMessageToConsole #

Patch Set 3 : Fixed worker console test #

Total comments: 6

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Total comments: 2

Patch Set 6 : PassRefPtr<ConsoleMessage> -> PassRefPtrWillBeRawPtr<ConsoleMessage> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -105 lines) Patch
M LayoutTests/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-in-console-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-in-internal-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Console.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Console.cpp View 1 2 3 4 5 1 chunk +3 lines, -8 lines 0 comments Download
M Source/core/frame/ConsoleBase.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/frame/ConsoleBase.cpp View 1 2 3 2 chunks +15 lines, -13 lines 0 comments Download
M Source/core/frame/FrameConsole.cpp View 1 2 3 3 chunks +30 lines, -10 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.h View 1 2 3 4 3 chunks +15 lines, -9 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.cpp View 1 2 3 4 3 chunks +47 lines, -30 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 4 chunks +18 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorConsoleMessage.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleMessage.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/workers/WorkerConsole.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/workers/WorkerConsole.cpp View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
kozyatinskiy1
@vsevik, please take a look!
6 years, 4 months ago (2014-08-18 14:24:40 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/472023002/diff/100001/Source/core/frame/ConsoleBase.idl File Source/core/frame/ConsoleBase.idl (right): https://chromiumcodereview.appspot.com/472023002/diff/100001/Source/core/frame/ConsoleBase.idl#newcode59 Source/core/frame/ConsoleBase.idl:59: [CallWith=(ScriptArguments,ScriptState)] void groupEnd(); Why did this change? I think ...
6 years, 4 months ago (2014-08-18 18:41:07 UTC) #2
kozyatinskiy1
https://codereview.chromium.org/472023002/diff/100001/Source/core/frame/ConsoleBase.idl File Source/core/frame/ConsoleBase.idl (right): https://codereview.chromium.org/472023002/diff/100001/Source/core/frame/ConsoleBase.idl#newcode59 Source/core/frame/ConsoleBase.idl:59: [CallWith=(ScriptArguments,ScriptState)] void groupEnd(); On 2014/08/18 18:41:06, vsevik wrote: > ...
6 years, 4 months ago (2014-08-19 07:31:06 UTC) #3
vsevik
lgtm https://codereview.chromium.org/472023002/diff/120001/Source/core/inspector/ConsoleMessage.h File Source/core/inspector/ConsoleMessage.h (right): https://codereview.chromium.org/472023002/diff/120001/Source/core/inspector/ConsoleMessage.h#newcode11 Source/core/inspector/ConsoleMessage.h:11: #include "core/inspector/ScriptArguments.h" Forward declaration should be enough. https://codereview.chromium.org/472023002/diff/120001/Source/core/inspector/InspectorConsoleMessage.h ...
6 years, 4 months ago (2014-08-19 08:04:55 UTC) #4
kozyatinskiy1
https://codereview.chromium.org/472023002/diff/120001/Source/core/inspector/ConsoleMessage.h File Source/core/inspector/ConsoleMessage.h (right): https://codereview.chromium.org/472023002/diff/120001/Source/core/inspector/ConsoleMessage.h#newcode11 Source/core/inspector/ConsoleMessage.h:11: #include "core/inspector/ScriptArguments.h" On 2014/08/19 08:04:54, vsevik wrote: > Forward ...
6 years, 4 months ago (2014-08-19 08:26:26 UTC) #5
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 4 months ago (2014-08-19 08:26:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/472023002/140001
6 years, 4 months ago (2014-08-19 08:27:35 UTC) #7
sof
https://codereview.chromium.org/472023002/diff/140001/Source/core/workers/WorkerConsole.h File Source/core/workers/WorkerConsole.h (right): https://codereview.chromium.org/472023002/diff/140001/Source/core/workers/WorkerConsole.h#newcode60 Source/core/workers/WorkerConsole.h:60: virtual void reportMessageToConsole(PassRefPtr<ConsoleMessage>) OVERRIDE; Please make this PassRefPtrWillBeRawPtr<ConsoleMessage> here ...
6 years, 4 months ago (2014-08-19 08:32:26 UTC) #8
kozyatinskiy1
The CQ bit was unchecked by kozyatinskiy@google.com
6 years, 4 months ago (2014-08-19 08:56:34 UTC) #9
kozyatinskiy1
https://codereview.chromium.org/472023002/diff/140001/Source/core/workers/WorkerConsole.h File Source/core/workers/WorkerConsole.h (right): https://codereview.chromium.org/472023002/diff/140001/Source/core/workers/WorkerConsole.h#newcode60 Source/core/workers/WorkerConsole.h:60: virtual void reportMessageToConsole(PassRefPtr<ConsoleMessage>) OVERRIDE; On 2014/08/19 08:32:26, sof wrote: ...
6 years, 4 months ago (2014-08-19 09:01:14 UTC) #10
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 4 months ago (2014-08-19 09:01:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/472023002/160001
6 years, 4 months ago (2014-08-19 09:01:54 UTC) #12
sof
On 2014/08/19 09:01:14, kozyatinskiy wrote: > https://codereview.chromium.org/472023002/diff/140001/Source/core/workers/WorkerConsole.h > File Source/core/workers/WorkerConsole.h (right): > > https://codereview.chromium.org/472023002/diff/140001/Source/core/workers/WorkerConsole.h#newcode60 > ...
6 years, 4 months ago (2014-08-19 09:04:00 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 10:08:42 UTC) #14
Message was sent while issue was closed. 
Committed patchset #6 (160001) as 180544

Powered by Google App Engine
This is Rietveld 408576698