Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 46853004: Move ExtensionPrefs and friends to extensions/ directory. (Closed)

Created:
7 years, 1 month ago by Daniel Erat
Modified:
6 years, 11 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), sadrul, tzik, jeremya+watch_chromium.org, dcheng, ajwong+watch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, kalyank, Avi (use Gerrit), jennb, creis+watch_chromium.org, jianli, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, Lei Zhang, tfarina, Dmitry Titov, tommycli, Greg Billock, nhiroki+watch_chromium.org, ben+ash_chromium.org, miket_OOO, James Cook
Visibility:
Public.

Description

Move ExtensionPrefs and friends to extensions/ directory. Move ExtensionPrefs and related classes from chrome/browser/extensions/ to the top-level extensions/ directory. The following classes are moved: ExtensionPrefStore ExtensionPrefValueMap ExtensionPrefValueMapFactory ExtensionPrefs ExtensionPrefsFactory ExtensionScopedPref The TestExtensionPrefs helper class and the ExtensionPrefsTest unit tests remain in chrome/browser/extensions, since TestExtensionPrefs has a dependency on Chrome's PrefServiceSyncable that seems like it will be difficult to break (more explanation at https://codereview.chromium.org/108643002/). BUG=313284 TBR=sky@chromium.org,pam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246373

Patch Set 1 #

Patch Set 2 : update #

Total comments: 4

Patch Set 3 : sync #

Patch Set 4 : apply review feedback #

Patch Set 5 : sync and update app_shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -3978 lines) Patch
M apps/app_load_service.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M apps/app_load_service_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/app_restore_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/app_restore_service_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/launcher.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M apps/saved_files_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/saved_files_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/shell/shell_extension_system.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M apps/shell/shell_extensions_browser_client.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M apps/shell_window_geometry_cache.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M apps/shell_window_geometry_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_service.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_service_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_runtime/app_runtime_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/module/module.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_helpers.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/blacklist.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/blacklist_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_app_sorting.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_app_sorting.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_app_sorting_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/dev_mode_bubble_controller.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_disabled_ui_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_pref_store.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/extensions/extension_pref_store.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/extensions/extension_pref_value_map.h View 1 1 chunk +0 lines, -198 lines 0 comments Download
D chrome/browser/extensions/extension_pref_value_map.cc View 1 1 chunk +0 lines, -376 lines 0 comments Download
D chrome/browser/extensions/extension_pref_value_map_factory.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/extensions/extension_pref_value_map_factory.cc View 1 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/extensions/extension_pref_value_map_unittest.cc View 1 1 chunk +0 lines, -400 lines 0 comments Download
D chrome/browser/extensions/extension_prefs.h View 1 1 chunk +0 lines, -637 lines 0 comments Download
D chrome/browser/extensions/extension_prefs.cc View 1 1 chunk +0 lines, -1893 lines 0 comments Download
D chrome/browser/extensions/extension_prefs_factory.h View 1 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/extensions/extension_prefs_factory.cc View 1 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/extensions/extension_scoped_prefs.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_service.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_service_factory.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_factory.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_verifier.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/launch_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_prefs.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_dialog_controller.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_permissions_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_test_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/recommended_apps.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_info_ui.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/DEPS View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M extensions/browser/app_sorting.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/event_router.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/extension_pref_store.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/extension_pref_store.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/browser/extension_pref_value_map.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/extension_pref_value_map.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/extension_pref_value_map_factory.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/extension_pref_value_map_factory.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/browser/extension_pref_value_map_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/extension_prefs.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
A + extensions/browser/extension_prefs.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
A + extensions/browser/extension_prefs_factory.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/extension_prefs_factory.cc View 1 2 chunks +6 lines, -8 lines 0 comments Download
A + extensions/browser/extension_scoped_prefs.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Daniel Erat
At last.
6 years, 11 months ago (2014-01-17 17:20:15 UTC) #1
Daniel Erat
(Adding Mike as a reviewer since Yoyo is out.)
6 years, 11 months ago (2014-01-17 22:37:07 UTC) #2
Yoyo Zhou
Yay! LGTM with a few. https://chromiumcodereview.appspot.com/46853004/diff/30001/extensions/browser/DEPS File extensions/browser/DEPS (right): https://chromiumcodereview.appspot.com/46853004/diff/30001/extensions/browser/DEPS#newcode20 extensions/browser/DEPS:20: "+chrome/browser/extensions/extension_prefs.h", delete this one ...
6 years, 11 months ago (2014-01-22 02:49:04 UTC) #3
Daniel Erat
TBR pam@ for components DEP and sky@ for include path updates https://codereview.chromium.org/46853004/diff/30001/extensions/browser/DEPS File extensions/browser/DEPS (right): ...
6 years, 11 months ago (2014-01-22 04:40:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/46853004/150001
6 years, 11 months ago (2014-01-22 04:42:46 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=170578
6 years, 11 months ago (2014-01-22 05:47:45 UTC) #6
Pam (message me for reviews)
Looks fine, but +joi FYI and a sanity check.
6 years, 11 months ago (2014-01-22 10:13:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/46853004/430001
6 years, 11 months ago (2014-01-22 13:54:39 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=193322
6 years, 11 months ago (2014-01-22 15:48:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/46853004/430001
6 years, 11 months ago (2014-01-22 15:52:11 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 18:20:16 UTC) #11
Message was sent while issue was closed. 
Change committed as 246373

Powered by Google App Engine
This is Rietveld 408576698