Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: Source/bindings/v8/DebuggerScript.js

Issue 466243002: Support merged Dart-JS callstacks (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/dart/DartScriptDebugServer.cpp ('k') | Source/bindings/v8/ScriptDebugServer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/DebuggerScript.js
diff --git a/Source/bindings/v8/DebuggerScript.js b/Source/bindings/v8/DebuggerScript.js
index 6973cf6979e689692351885792a66a9681c22f36..1be78b85073bc1254d296686d732b21ecc8df9fd 100644
--- a/Source/bindings/v8/DebuggerScript.js
+++ b/Source/bindings/v8/DebuggerScript.js
@@ -351,6 +351,8 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame, sc
var thisObject = frameDetails.receiver();
var isAtReturn = !!frameDetails.isAtReturn();
+ var cachedFramePointerHigh = frameDetails.framePointerHigh();
+ var cachedFramePointerLow = frameDetails.framePointerLow();
var returnValue = isAtReturn ? frameDetails.returnValue() : undefined;
var scopeMirrors = (scopeDetailsLevel === DebuggerScript.ScopeInfoDetails.NoScopes ? [] : frameMirror.allScopes(scopeDetailsLevel === DebuggerScript.ScopeInfoDetails.FastAsyncScopes));
@@ -434,6 +436,14 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame, sc
return scriptId;
}
+ function framePointerHigh() {
+ return cachedFramePointerHigh;
+ }
+
+ function framePointerLow() {
+ return cachedFramePointerLow;
+ }
+
function functionName()
{
// FIXMEDART: remove caching when Dart devtools refactor CL lands.
@@ -501,6 +511,8 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame, sc
"setVariableValue": setVariableValue,
"stepInPositions": stepInPositions,
"isAtReturn": isAtReturn,
+ "framePointerHigh": framePointerHigh,
+ "framePointerLow": framePointerLow,
"returnValue": returnValue
};
}
« no previous file with comments | « Source/bindings/dart/DartScriptDebugServer.cpp ('k') | Source/bindings/v8/ScriptDebugServer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698