Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: Source/core/inspector/InspectorConsoleAgent.h

Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-can-generate
Patch Set: Rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorConsoleAgent.h
diff --git a/Source/core/inspector/InspectorConsoleAgent.h b/Source/core/inspector/InspectorConsoleAgent.h
index e40d381f48edd4abd9c59cff65732559b17488de..cfa14254c50509380e8be834239a31ac7a0f2b9d 100644
--- a/Source/core/inspector/InspectorConsoleAgent.h
+++ b/Source/core/inspector/InspectorConsoleAgent.h
@@ -41,10 +41,10 @@
namespace blink {
class ConsoleMessage;
+class ConsoleMessageStorage;
class DocumentLoader;
class LocalDOMWindow;
class LocalFrame;
-class InspectorConsoleMessage;
class InspectorFrontend;
class InjectedScriptManager;
class InspectorTimelineAgent;
@@ -81,8 +81,9 @@ public:
virtual void restore() OVERRIDE FINAL;
void addConsoleAPIMessageToConsole(MessageType, MessageLevel, const String& message, ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>, unsigned long requestIdentifier = 0);
- void addMessageToConsole(ConsoleMessage*);
+ void addMessageToConsole(PassRefPtr<ConsoleMessage>);
void adoptWorkerConsoleMessages(WorkerGlobalScopeProxy*);
+
Vector<unsigned> consoleMessageArgumentCounts();
void consoleTime(ExecutionContext*, const String& title);
@@ -108,14 +109,14 @@ public:
virtual bool isWorkerAgent() = 0;
protected:
- void addConsoleMessage(PassOwnPtr<InspectorConsoleMessage>);
+ void storeConsoleMessage(PassRefPtr<ConsoleMessage>);
+ void sendConsoleMessageToFrontend(PassRefPtr<ConsoleMessage>, bool generatePreview);
+ virtual ConsoleMessageStorage* messageStorage() = 0;
RawPtrWillBeMember<InspectorTimelineAgent> m_timelineAgent;
RawPtrWillBeMember<InspectorTracingAgent> m_tracingAgent;
RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
InspectorFrontend::Console* m_frontend;
- Vector<OwnPtr<InspectorConsoleMessage> > m_consoleMessages;
- int m_expiredConsoleMessageCount;
HashCountedSet<String> m_counts;
HashMap<String, double> m_times;
bool m_enabled;

Powered by Google App Engine
This is Rietveld 408576698