[DevTools] ConsoleMessage storage moved from ConsoleAgent

Source/core/frame/FrameConsole.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 47 matching lines @@
     if (muteCount)
         return;
 
     // FIXME: This should not need to reach for the main-frame.
     // Inspector code should just take the current frame and know how to walk itself.
     ExecutionContext* context = m_frame.document();
     if (!context)
         return;
 
     RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = prpConsoleMessage;
-    InspectorInstrumentation::addMessageToConsole(context, consoleMessage.get());
 
+    unsigned lineNumber = consoleMessage->lineNumber();

[vsevik, 2014/08/14 08:06:21]

This one is worth a comment, or even a FIXME since we are probably going to
remove this in a separate patch.

[kozyatinskiy1, 2014/08/20 13:44:18]

It was moved to another patch.

     String messageURL;
-    if (consoleMessage->callStack())
+    if (consoleMessage->callStack() && consoleMessage->callStack()->size())
         messageURL = consoleMessage->callStack()->at(0).sourceURL();
     else
         messageURL = consoleMessage->url();
 
+    ConsoleMessageStorage* storage = messageStorage();

[vsevik, 2014/08/14 08:06:21]

This method does two things
1) Report the message to embedder
2) store the message

Cold you please make sure this is emphasized by the code layout?

[kozyatinskiy1, 2014/08/20 13:44:18]

Done.

+    if (storage)

[vsevik, 2014/08/14 08:06:21]

Let's assume this is never null and move 
 InspectorInstrumentation call to the storage impl.

[kozyatinskiy1, 2014/08/20 13:44:18]

Done.

+        storage->addMessage(consoleMessage);
+    InspectorInstrumentation::addMessageToConsole(context, consoleMessage);
+
     if (consoleMessage->source() == CSSMessageSource)
         return;
 
     String stackTrace;
     if (consoleMessage->callStack() && m_frame.chromeClient().shouldReportDetailedMessageForSource(consoleMessage->url()))
         stackTrace = FrameConsole::formatStackTraceString(consoleMessage->message(), consoleMessage->callStack());
 
-    m_frame.chromeClient().addMessageToConsole(&m_frame, consoleMessage->source(), consoleMessage->level(), consoleMessage->message(), consoleMessage->lineNumber(), messageURL, stackTrace);
+    m_frame.chromeClient().addMessageToConsole(&m_frame, consoleMessage->source(), consoleMessage->level(), consoleMessage->message(), lineNumber, messageURL, stackTrace);
 }
 
 String FrameConsole::formatStackTraceString(const String& originalMessage, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)
 {
     StringBuilder stackTrace;
     for (size_t i = 0; i < callStack->size(); ++i) {
         const ScriptCallFrame& frame = callStack->at(i);
         stackTrace.append("\n    at " + (frame.functionName().length() ? frame.functionName() : "(anonymous function)"));
         stackTrace.append(" (");
         stackTrace.append(frame.sourceURL());
@@ skipping 16 matching lines @@
 {
     ASSERT(muteCount > 0);
     muteCount--;
 }
 
 void FrameConsole::adoptWorkerConsoleMessages(WorkerGlobalScopeProxy* proxy)
 {
     InspectorInstrumentation::adoptWorkerConsoleMessages(m_frame.document(), proxy);
 }
 
+ConsoleMessageStorage* FrameConsole::messageStorage()
+{

[vsevik, 2014/08/14 08:06:22]

LocalFrame* localTopFrame = toLocalFrame(curFrame->tree().top());
return localTopFrame ? localTopFrame->console().messageStorage() :
messageStorage();

[kozyatinskiy1, 2014/08/20 13:44:18]

Done.

+    LocalFrame* curFrame = &m_frame;
+    // traversal to top frame
+    while (curFrame && curFrame->tree().parent() && curFrame->tree().parent()->isLocalFrame())
+        curFrame = toLocalFrame(curFrame->tree().parent());
+
+    // if top is current - return storage
+    if (curFrame == &m_frame) {
+        if (m_consoleMessageStorage.get())
+            return m_consoleMessageStorage.get();
+        m_consoleMessageStorage = ConsoleMessageStorage::create();
+        return m_consoleMessageStorage.get();
+    }
+
+    // if top is local - return storage
+    if (curFrame->isLocalFrame())
+        return curFrame->console().messageStorage();
+
+    return nullptr;
+}
+
 } // namespace blink